1097147 - Unicode errors on query strings with the redirect middleware

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[David Larlet [:davidbgk]]

See http://sentry.mktmon.services.phx1.mozilla.com/mkt/addonsmozillaorg/group/5515/

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 88, in get_response
    response = middleware_method(request)
  File "amo/middleware.py", line 66, in process_request
    response = redirect_type(full_path)
  File "django/http/response.py", line 457, in __init__
    parsed = urlparse(force_text(redirect_to))
  File "django/utils/encoding.py", line 116, in force_text
    raise DjangoUnicodeDecodeError(s, *e.args)

DjangoUnicodeDecodeError: 'utf8' codec can't decode byte 0x85 in position 67: invalid start byte. You passed in '/en-US/firefox/collections/mozmj/autumn/?source=firefoxsocialmedia\x14\x85' (<type 'str'>)

Comment 1

[David Larlet [:davidbgk]]

PR: https://github.com/mozilla/olympia/pull/362

Comment 2

[David Larlet [:davidbgk]]

https://github.com/mozilla/olympia/commit/03c09bb480faaff437bea2c6ee9b341b954c79ed

Comment 3

[David Larlet [:davidbgk]]

Reverted in https://github.com/mozilla/olympia/pull/364 because Python 2.6 doesn't allow errors='ignore'. It will probably end with a try/except dropping the query_string in case of error.

Comment 4

[Mathieu Agopian [:magopian]]

PR https://github.com/mozilla/olympia/pull/403

The only thing not supported in py26 is the use of named parameters in the decode function, so that's the only thing I changed ;)

Comment 5

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/0262a6ece95d3830b9b5c6c01557891ef48e1367