1097173 - fix libzmq dependency

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

If you have a version of zmq installed that isn't 4.0.4, you get:

export LANG=en_US.UTF-8; \
npm install marionette-socket-host
npm WARN package.json dateformat@1.0.6-1.2.3 No repository field.
npm WARN package.json marionette-content-script@0.0.4 No repository field.
npm WARN package.json marionette-device-host@0.1.0 No repository field.
npm WARN package.json marionette-file-manager@0.0.2 No repository field.
npm WARN package.json marionette-profile-builder@0.0.3 No repository field.
npm WARN package.json mocha-json-proxy@0.0.7 No repository field.
npm WARN package.json mocha-parallel@0.1.0 No repository field.
npm WARN package.json marionette-client@1.3.0 No repository field.
|
> marionette-socket-host@0.1.0 preinstall /Users/mozilla/GitRepo/gaia/node_modules/marionette-socket-host
> ./scripts/preinstall.sh

./scripts/preinstall.sh: line 6: pkg-config: command not found
installing zmq from brew
/usr/local/bin/brew
Warning: zeromq-4.0.5_1 already installed
npm WARN deprecated set-immediate@0.1.1: Use `setimmediate` instead
|
> zmq@2.6.0 install /Users/mozilla/GitRepo/gaia/node_modules/marionette-socket-host/node_modules/corredor-js/node_modules/zmq
> node-gyp rebuild

/bin/sh: pkg-config: command not found
gyp: Call to 'pkg-config libzmq --libs' returned exit status 127. while trying to load binding.gyp
gyp ERR! configure error 
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:343:16)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:807:12)
gyp ERR! System Darwin 14.0.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/mozilla/GitRepo/gaia/node_modules/marionette-socket-host/node_modules/corredor-js/node_modules/zmq
gyp ERR! node -v v0.10.28
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok 
npm ERR! Darwin 14.0.0
npm ERR! argv "node" "/usr/local/bin/npm" "install" "marionette-socket-host"
npm ERR! node v0.10.28
npm ERR! npm  v2.1.6
npm ERR! code ELIFECYCLE

npm ERR! zmq@2.6.0 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the zmq@2.6.0 install script.
npm ERR! This is most likely a problem with the zmq package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls zmq
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/mozilla/GitRepo/gaia/npm-debug.log
make[1]: *** [node_modules] Error 1
make: *** [test-integration-test] Error 2

we should depend on 4.0.4 or greater, not strictly 4.0.4

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

That's not the problem, it's failing to detect that zmq is already installed. likely "pkg-config libzmq --exists;" doesn't return true, so it may be that zmq is installed but libzmq.pc isn't on the PKG_CONFIG_PATH. I'll add additional verification

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: link to PR

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 8520816 [details] [review]
link to PR

https://github.com/mozilla-b2g/marionette-socket-host/commit/81a780e4ac750379b2c66b33593924bbe5535a30