1097181 - lazyRequireGetter incorrectly bound to main loader

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

lazyRequireGetter always loads via the "main" devtools loader, which leads to incorrect behavior if used from server-side code, which can be in multiple distinct loaders at the same time.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: bz://1097181/jryans

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

/r/427 - Bug 1097181 - lazyRequireGetter shouldn't bind to the main loader. r=fitzgen

Pull down this commit:

hg pull review -r c19c479495f055a6efaac9b9bb1cd4fcd0cd58ce

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=72301d538847

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8520805 [details]
MozReview Request: bz://1097181/jryans

Looks good to me!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2baa26884f10

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2baa26884f10

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1097181 - lazyRequireGetter shouldn't bind to the main loader. r=fitzgen