lazyRequireGetter incorrectly bound to main loader

RESOLVED FIXED in Firefox 36

Status

RESOLVED FIXED
4 years ago
5 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

unspecified
Firefox 36
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
lazyRequireGetter always loads via the "main" devtools loader, which leads to incorrect behavior if used from server-side code, which can be in multiple distinct loaders at the same time.
(Assignee)

Comment 1

4 years ago
Created attachment 8520805 [details]
MozReview Request: bz://1097181/jryans
Attachment #8520805 - Flags: review?(nfitzgerald)
(Assignee)

Comment 2

4 years ago
/r/427 - Bug 1097181 - lazyRequireGetter shouldn't bind to the main loader. r=fitzgen

Pull down this commit:

hg pull review -r c19c479495f055a6efaac9b9bb1cd4fcd0cd58ce
(Assignee)

Updated

4 years ago
Blocks: 1058997
Comment on attachment 8520805 [details]
MozReview Request: bz://1097181/jryans

Looks good to me!
Attachment #8520805 - Flags: review?(nfitzgerald) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/2baa26884f10
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2baa26884f10
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
(Assignee)

Comment 7

4 years ago
Comment on attachment 8520805 [details]
MozReview Request: bz://1097181/jryans
Attachment #8520805 - Attachment is obsolete: true
Attachment #8618599 - Flags: review+
(Assignee)

Comment 8

4 years ago
Created attachment 8618599 [details]
MozReview Request: Bug 1097181 - lazyRequireGetter shouldn't bind to the main loader. r=fitzgen

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.