Closed Bug 1097181 Opened 7 years ago Closed 7 years ago

lazyRequireGetter incorrectly bound to main loader

Categories

(DevTools :: Framework, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file, 1 obsolete file)

lazyRequireGetter always loads via the "main" devtools loader, which leads to incorrect behavior if used from server-side code, which can be in multiple distinct loaders at the same time.
/r/427 - Bug 1097181 - lazyRequireGetter shouldn't bind to the main loader. r=fitzgen

Pull down this commit:

hg pull review -r c19c479495f055a6efaac9b9bb1cd4fcd0cd58ce
Comment on attachment 8520805 [details]
MozReview Request: bz://1097181/jryans

Looks good to me!
Attachment #8520805 - Flags: review?(nfitzgerald) → review+
https://hg.mozilla.org/integration/fx-team/rev/2baa26884f10
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2baa26884f10
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Attachment #8520805 - Attachment is obsolete: true
Attachment #8618599 - Flags: review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.