1097238 - Non-ASCII input with GTK_IM_MODULE=xim broken after bug 1083067

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Log messages from before the regression

I have GTK_IM_MODULE=xim set in my environment, and trying to input non-ASCII characters with the X11 Compose key (e.g., Compose-a-e for æ) no longer works as of this commit:

changeset:   214824:da7bac23b9f2
user:        Masayuki Nakano <[e-mail]>
date:        Mon Nov 10 18:07:42 2014 +0900
summary:     Bug 1083067 part.1 Create nsGtkIMModule::DispatchCompositionEventsForCommit() r=m_kato

I have logs from debug builds with NSPR_LOG_MODULES=nsGtkIMModuleWidgets:5 before and after that patch.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Log messages from after the regression

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, okay. That's very simple mistake. Thank you, the log really helped me!

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: nsGtkIMModule::DispatchCompositionEventsForCommit() should start composition if there is no composition but committing non-empty string

At using dead key, only OnCommitCompositionNative() is called. I.e., only commit string is notified by IME.

In DispatchCompositionChangeEvent(), this case causes dispatching compositionstart and commit the composition immediately.
http://mxr.mozilla.org/mozilla-central/source/widget/gtk/nsGtkIMModule.cpp#1043

So, DispatchCompositionEventsForCommit() should do it when commit string is not empty.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you!

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed429f98e1eb

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ed429f98e1eb