1097260 - loadedmetadata event must be emitted once we know the video element dimension

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

In bug 1092979, we added a mochitest to make sure the loadedmetadata event was fired as early as possible.

We should also check that the video dimensions are known.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Ensure video dimensions are known when loadedmetadata is fired

Test for video dimensions

Comment 2

[cajbir (:cajbir)]

Comment on attachment 8521033 [details] [diff] [review]
Ensure video dimensions are known when loadedmetadata is fired

Review of attachment 8521033 [details] [diff] [review]:
-----------------------------------------------------------------

Is it worth checking if these values are the expected value?

Comment 3

[Jean-Yves Avenard [:jya]]

(In reply to cajbir (:cajbir) from comment #2)
> Comment on attachment 8521033 [details] [diff] [review]
> Ensure video dimensions are known when loadedmetadata is fired
> 
> Review of attachment 8521033 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is it worth checking if these values are the expected value?

probably, but then it's a much bigger change :)

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Ensure video dimensions are known when loadedmetadata is fired

Adding actual dimensions check

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8521173 [details] [diff] [review]
Ensure video dimensions are known when loadedmetadata is fired

is(actual, expected) is preferred over ok(actual == expected).  It logs actual and expected so there's no need to construct the complicated log string by hand.

Comment 6

[Jean-Yves Avenard [:jya]]

Attachment: Ensure video dimensions are known when loadedmetadata is fired

Comment 7

[Jean-Yves Avenard [:jya]]

Attachment: Ensure video dimensions are known when loadedmetadata is fired

Updated as per kinetik's instructions

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please run this through Try first (or post a link and re-request checkin if you already have).

Comment 9

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e4b14ad0cfaf

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4819ef5bb245

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4819ef5bb245

Comment 12

[cjansss]

Not sure this is properly fixed for WebRTC at least.

When attaching a mediaStream to video.srcObject the loadedmetadata event is fired however the video.videoWidth and video.videoHeight are 0 until the first frame is received which happens on play.

According to the spec[1] the loadedmetadata event should be fired when:
The user agent has just determined the duration and dimensions of the media resource and the text tracks are ready.

http://dev.w3.org/html5/spec-preview/media-elements.html#event-media-loadedmetadata

Comment 13

[cjansss]

Doh, ignore my comment. The event is never fired due to the reason mentioned (dimensions are not know until play).

Comment 14

[Andreas Pehrson [:pehrsons]]

That should still work. Let me file a bug.