Closed
Bug 1097260
Opened 10 years ago
Closed 10 years ago
loadedmetadata event must be emitted once we know the video element dimension
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(1 file, 3 obsolete files)
In bug 1092979, we added a mochitest to make sure the loadedmetadata event was fired as early as possible. We should also check that the video dimensions are known.
Assignee | ||
Comment 1•10 years ago
|
||
Test for video dimensions
Attachment #8521033 -
Flags: review?(cajbir.bugzilla)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8521033 [details] [diff] [review] Ensure video dimensions are known when loadedmetadata is fired Review of attachment 8521033 [details] [diff] [review]: ----------------------------------------------------------------- Is it worth checking if these values are the expected value?
Attachment #8521033 -
Flags: review?(cajbir.bugzilla) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to cajbir (:cajbir) from comment #2) > Comment on attachment 8521033 [details] [diff] [review] > Ensure video dimensions are known when loadedmetadata is fired > > Review of attachment 8521033 [details] [diff] [review]: > ----------------------------------------------------------------- > > Is it worth checking if these values are the expected value? probably, but then it's a much bigger change :)
Assignee | ||
Comment 4•10 years ago
|
||
Adding actual dimensions check
Assignee | ||
Updated•10 years ago
|
Attachment #8521033 -
Attachment is obsolete: true
Comment 5•10 years ago
|
||
Comment on attachment 8521173 [details] [diff] [review] Ensure video dimensions are known when loadedmetadata is fired is(actual, expected) is preferred over ok(actual == expected). It logs actual and expected so there's no need to construct the complicated log string by hand.
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8521173 -
Attachment is obsolete: true
Assignee | ||
Comment 7•10 years ago
|
||
Updated as per kinetik's instructions
Assignee | ||
Updated•10 years ago
|
Attachment #8521238 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Please run this through Try first (or post a link and re-request checkin if you already have).
Keywords: checkin-needed
Assignee | ||
Comment 9•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e4b14ad0cfaf
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4819ef5bb245
Keywords: checkin-needed
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4819ef5bb245
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment 12•8 years ago
|
||
Not sure this is properly fixed for WebRTC at least. When attaching a mediaStream to video.srcObject the loadedmetadata event is fired however the video.videoWidth and video.videoHeight are 0 until the first frame is received which happens on play. According to the spec[1] the loadedmetadata event should be fired when: The user agent has just determined the duration and dimensions of the media resource and the text tracks are ready. http://dev.w3.org/html5/spec-preview/media-elements.html#event-media-loadedmetadata
Comment 13•8 years ago
|
||
Doh, ignore my comment. The event is never fired due to the reason mentioned (dimensions are not know until play).
Comment 14•8 years ago
|
||
That should still work. Let me file a bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•