Closed Bug 1097438 Opened 10 years ago Closed 10 years ago

nsCSSRenderingBorders::DrawBorders creates unused DrawOptions

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: roc, Assigned: jwatt)

References

Details

Attachments

(1 file)

DrawOptions drawOptions;
    drawOptions.mAntialiasMode = AntialiasMode::NONE;
    mDrawTarget->StrokeRect(rect, color, strokeOptions);

drawOptions should be passed to StrokeRect. Or else it should be removed altogether. I'm not sure why we disabled antialiasing here (performance maybe?).
Regression from Moz2D conversion I guess. jwatt can decide what to do :-)
Assignee: roc → jwatt
Attached patch patchSplinter Review
Oops. That was silly!
Attachment #8521106 - Flags: review?(roc)
Blocks: 1092392
Attachment #8521106 - Flags: review?(roc) → review+
https://hg.mozilla.org/mozilla-central/rev/4e3f630d1087
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.