1097446 - Provide flow diagrams for input management

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

After bug 1093537 lands, we're mostly done with the current iteration of (big) input management refactoring. Why not draw some diagrams for input management flows?

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

On this.

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

Tim, could you check this? I believe the flows-logics of the diagrams themselves are pretty fine (they're just "codify"ing the codes) and we don't need to involve Alive here?

With that said, of course, style-related comments are welcome.

Also, I do have two questions -- what is usually the best place to host the images? and what do we usually do for long URLs that break the linter limit?

Thanks!

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8523794 [details] [review]
Patch (PR @ GitHub)

Let's do this on MDN or Wiki instead. An approach patch would be a link to these documentations instead of Github.

I have not yet look at the diagrams.

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8523794 [details] [review]
Patch (PR @ GitHub)

Files are now hosted on Mozilla Wiki.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8523794 [details] [review]
Patch (PR @ GitHub)

As the diagram explains the current state of the code (not the eventual, ideal arch we want to achieve), I have no opinion on it.

Let's point people to 
https://wiki.mozilla.org/Gaia/System/InputManagement instead of the actual images because you do not want to submit a patch every time the diagram changes :)

Also, SVG is better than PNG if WikiMO accept that.

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

Just checked and the wiki seems to support svg uploading. Let me see...

Comment 7

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/d93eb7854aa269ab3aed5f851b8b01c9c1a07c7f

Note: I landed the patch as soon as Li went green as this is just comments change.

Diagrams are on that wiki page too. (it seems to have trouble rendering svn previews so I'm using PNG as thumbnail and link target as SVG).