Incorrect locales result in profile/webapps

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rickychien, Assigned: rickychien)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

With GAIA_CONCAT_LOCALES=1 LOCALE_BASEDIR=../gaia-l10n/ LOCALES_FILE=locales/languages_dev.json make, there are some inconsistent results in locales-obj/ between Mac and Linux. (Windows is same as Mac)

And we also skip to remove redundant *.properties with GAIA_CONCAT_LOCALES=0 after bug 1070442 was landed.
(Assignee)

Comment 1

4 years ago
The issue regarding inconsistent results in locales-obj/ between Mac and Linux seems to not happen. But we still have to deal with the problem with redundant *.properties with GAIA_CONCAT_LOCALES=0.
(Assignee)

Updated

4 years ago
Assignee: nobody → ricky060709
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 8522046 [details] [review]
Gaia PR

Please forget comment 1, problem occur in |GAIA_CONCAT_LOCALES=0 LOCALE_BASEDIR=../gaia-l10n/ LOCALES_FILE=locales/languages_dev.json make|. Because we don't clean all locales/ files in bug 1070442 so that generate some redundant *.properties if we just pass a few language options in languages_dev.json. (ex: only "en-US")

PR was submitted.
Attachment #8522046 - Flags: review?(gduan)
Comment on attachment 8522046 [details] [review]
Gaia PR

r=gduan!
Attachment #8522046 - Flags: review?(gduan) → review+
(Assignee)

Comment 4

4 years ago
Cool thanks!

Merged.

https://github.com/mozilla-b2g/gaia/commit/5e7fa5c012d41f6f13c5a0892ae8c244c5370d78
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.