1097575 - [Messages] Number of empty contenteditable spans inside recipients input is constantly growing if user removes all typed characters

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

STR:
1. Open Messages app and go to message composer;
2. Focus on recipients input;
3. Enter just one character and remove it;
4. Repeat step #3 several times and observe recipients container (#messages-recipients-list) in dev tools inspector.

Expected result: there should be only one contenteditable span;

Actual result: number of empty contenteditable spans is constantly growing when you repeat step #3.

It happens only if user enters first recipient and also all redundant spans are got rid of once user confirms (assimilates) recipient so it's not that critical, but nice to fix anyway.

Comment 1

[Oleg Zasypkin [:azasypkin]]

Well, it'll likely become a problem once contenteditable element if forced to always have at least one <br> inside, in this case we'll have several focusable areas inside recipients input.

Comment 2

[Julien Wajsberg [:julienw]]

I think we set a "width: 0" on empty placeholders (but we handle the tap event on the whole panel and focus them programmatically). Need to check this though.

Comment 3

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> I think we set a "width: 0" on empty placeholders (but we handle the tap
> event on the whole panel and focus them programmatically). Need to check
> this though.

Nope, there is "width: auto" + "flex-grow: 1" (that will make things even worse, but I was going to remove it in bug 1080832 because "we handle the tap event on the whole panel and focus them programmatically" is more than enough)

Comment 4

[Oleg Zasypkin [:azasypkin]]

One more note: we use ".recipient[contenteditable=true]:empty:not(:last-of-type)" to hide these redundant spans. :empty part won't match once we have anything inside, eg. <br> :)

Comment 5

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 6

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(