Closed Bug 1097615 Opened 5 years ago Closed 5 years ago

add MOZ_OVERRIDE annotations to subclasses of gfxFont

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jfkthame, Assigned: jfkthame)

Details

Attachments

(1 file)

Over in bug 1089787, I stumbled across the fact that we don't have MOZ_OVERRIDE annotations in the various platform implementations of gfxFont. (This meant that the original patch there would have still applied and compiled successfully after the gfxContext -> DrawTarget parameter change from bug 1093811, but would have silently failed to work any longer.)

Override annotations will help us notice if the signature of a base-class method changes, which is a Good Thing in general.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8521362 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/5e993b51246b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.