Closed
Bug 1097615
Opened 10 years ago
Closed 10 years ago
add MOZ_OVERRIDE annotations to subclasses of gfxFont
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
13.69 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
Over in bug 1089787, I stumbled across the fact that we don't have MOZ_OVERRIDE annotations in the various platform implementations of gfxFont. (This meant that the original patch there would have still applied and compiled successfully after the gfxContext -> DrawTarget parameter change from bug 1093811, but would have silently failed to work any longer.) Override annotations will help us notice if the signature of a base-class method changes, which is a Good Thing in general.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8521362 -
Flags: review?(jdaggett)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8521362 -
Flags: review?(jdaggett) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e993b51246b
Target Milestone: --- → mozilla36
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5e993b51246b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•