add MOZ_OVERRIDE annotations to subclasses of gfxFont

RESOLVED FIXED in mozilla36

Status

()

Core
Graphics: Text
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Over in bug 1089787, I stumbled across the fact that we don't have MOZ_OVERRIDE annotations in the various platform implementations of gfxFont. (This meant that the original patch there would have still applied and compiled successfully after the gfxContext -> DrawTarget parameter change from bug 1093811, but would have silently failed to work any longer.)

Override annotations will help us notice if the signature of a base-class method changes, which is a Good Thing in general.
(Assignee)

Comment 1

4 years ago
Created attachment 8521362 [details] [diff] [review]
Add MOZ_OVERRIDE annotations to subclasses of gfxFont.
Attachment #8521362 - Flags: review?(jdaggett)
(Assignee)

Updated

4 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED

Updated

4 years ago
Attachment #8521362 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/5e993b51246b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.