Over in bug 1089787, I stumbled across the fact that we don't have MOZ_OVERRIDE annotations in the various platform implementations of gfxFont. (This meant that the original patch there would have still applied and compiled successfully after the gfxContext -> DrawTarget parameter change from bug 1093811, but would have silently failed to work any longer.) Override annotations will help us notice if the signature of a base-class method changes, which is a Good Thing in general.
Created attachment 8521362 [details] [diff] [review] Add MOZ_OVERRIDE annotations to subclasses of gfxFont.
Attachment #8521362 - Flags: review?(jdaggett)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla36
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.