1097627 - Error using usePrivateBrowsing in gaia

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: General, defect)

Description

[Kevin Grandon :kgrandon]

I was playing around earlier, and I get this error when setting the private browsing attribute in the system app:

W/Browser ( 1352): [JavaScript Warning: "Only internal code is allowed to set the usePrivateBrowsing attribute" {file: "chrome://global/content/BrowserElementChild.js" line: 63}]

Comment 1

[Kevin Grandon :kgrandon]

Fabrice - do you want to look into this?

Comment 2

[[:fabrice] Fabrice Desré]

Well, what did you do exactly? We have tests at https://mxr.mozilla.org/mozilla-central/source/dom/browser-element/mochitest/ (test_browserElement_inproc_PrivateBrowsing.html and test_browserElement_oop_PrivateBrowsing.html) that don't seem to hit that error...

Comment 3

[Kevin Grandon :kgrandon]

I have a patch now in bug 1081731. After applying that, I see these errors in logcat.

Comment 4

[[:fabrice] Fabrice Desré]

I can't repro with your patch. Do you have explicit STR? I opened private browsing windows both from the context menu and from the browser frame menu with no problem.

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Fabrice Desré [:fabrice] from comment #4)
> I can't repro with your patch. Do you have explicit STR? I opened private
> browsing windows both from the context menu and from the browser frame menu
> with no problem.

My STR is:
1 - Load the patch from bug 1081731
2 - Load any website
3 - Click the context menu -> new private window

As soon as I do this I see the error in logcat. Note: the error logs as it's in the "Browser" process, and not gecko or the system app. There is no visual impact to the user, it only shows up in logcat.

Comment 6

[[:fabrice] Fabrice Desré]

Weird, I definitely can't reproduce.