Closed Bug 1097655 Opened 10 years ago Closed 10 years ago

crash in mozilla::layers::LayerTransactionChild::IPCOpen() const

Categories

(Core :: Graphics: Layers, defect)

All
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox35 --- wontfix
firefox36 --- fixed
b2g-v2.1 --- fixed
b2g-v2.1S --- fixed
b2g-v2.2 --- fixed

People

(Reporter: martijn.martijn, Assigned: milan)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

I just got this crash with a recent trunk build on the Flame (188 base image), while switching browser windows.

This bug was filed from the Socorro interface and is 
report bp-37ae9972-e5e2-475d-a964-dbf302141112.
=============================================================
0 	libxul.so 	mozilla::layers::LayerTransactionChild::IPCOpen() const 	/builds/slave/b2g_m-cen_flm-kk_eng_ntly-0000/build/objdir-gecko/dist/include/mozilla/layers/LayerTransactionChild.h:43
1 	libxul.so 	mozilla::layers::ShadowLayerForwarder::IsSameProcess() const 	gfx/layers/ipc/ShadowLayers.cpp
2 	libxul.so 	mozilla::layers::ShadowLayerForwarder::EndTransaction(nsTArray<mozilla::layers::EditReply>*, nsIntRegion const&, unsigned long long, bool, unsigned int, bool, mozilla::TimeStamp const&, bool*) 	gfx/layers/ipc/ShadowLayers.cpp
3 	libxul.so 	mozilla::layers::ClientLayerManager::ForwardTransaction(bool) 	gfx/layers/client/ClientLayerManager.cpp
4 	libxul.so 	mozilla::layers::ClientLayerManager::EndTransaction(void (*)(mozilla::layers::PaintedLayer*, gfxContext*, nsIntRegion const&, mozilla::layers::DrawRegionClip, nsIntRegion const&, void*), void*, mozilla::layers::LayerManager::EndTransactionFlags) 	gfx/layers/client/ClientLayerManager.cpp
5 	libxul.so 	nsDisplayList::PaintRoot(nsDisplayListBuilder*, nsRenderingContext*, unsigned int) 	layout/base/nsDisplayList.cpp
6 	libxul.so 	nsLayoutUtils::PaintFrame(nsRenderingContext*, nsIFrame*, nsRegion const&, unsigned int, unsigned int) 	layout/base/nsLayoutUtils.cpp
7 	libxul.so 	PresShell::Paint(nsView*, nsRegion const&, unsigned int) 	layout/base/nsPresShell.cpp
8 	libxul.so 	nsViewManager::ProcessPendingUpdatesPaint(nsIWidget*) 	view/nsViewManager.cpp
9 	libxul.so 	nsViewManager::ProcessPendingUpdatesForView(nsView*, bool) 	view/nsViewManager.cpp
10 	libxul.so 	nsRefreshDriver::Tick(long long, mozilla::TimeStamp) 	layout/base/nsRefreshDriver.cpp
Comment on attachment 8525546 [details] [diff] [review]
One more place to check for valid shadow manager. r=sotaro

good catch!
Attachment #8525546 - Flags: review?(sotaro.ikeda.g) → review+
For checkin-needed: trivial change (null pointer check before calling a function on it), no try push, let me know if I should do one anyway.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/565121755b11
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment on attachment 8525546 [details] [diff] [review]
One more place to check for valid shadow manager. r=sotaro

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 1124551
User impact if declined: Crash happens
Testing completed: Run Monkey test
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: None.
Attachment #8525546 - Flags: approval-mozilla-b2g34?
Attachment #8525546 - Flags: approval-mozilla-b2g34? → approval-mozilla-b2g34+
You need to log in before you can comment on or make changes to this bug.