Show subject if exists in the outgoing/incoming call

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: crdlc, Assigned: crdlc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Assignee)

Updated

3 years ago
Blocks: 1097529
(Assignee)

Updated

3 years ago
Depends on: 1097691
OS: All → Gonk (Firefox OS)
Hardware: All → ARM
(Assignee)

Updated

3 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Blocks: 1098563
(Assignee)

Updated

3 years ago
Summary: Show subject if exists in the outgoing call → Show subject if exists in the outgoing/incoming call
(Assignee)

Comment 1

3 years ago
Created attachment 8532066 [details]
Github pull request
Attachment #8532066 - Flags: review?(borja.bugzilla)
(Assignee)

Comment 2

3 years ago
Created attachment 8532067 [details]
subject_call_screen_1.jpeg
Attachment #8532067 - Flags: ui-review?(b.pmm)
(Assignee)

Comment 3

3 years ago
Created attachment 8532068 [details]
subject_call_screen_2.jpeg
Attachment #8532068 - Flags: ui-review?(b.pmm)
(Assignee)

Comment 4

3 years ago
Created attachment 8532069 [details]
subject_call_screen_3.jpeg
Attachment #8532069 - Flags: ui-review?(b.pmm)
(Assignee)

Comment 5

3 years ago
Created attachment 8532070 [details]
subject_call_screen_4.jpeg
Attachment #8532070 - Flags: ui-review?(b.pmm)
As Pau in on PTO and we are really in a hurry to land everything in the next two weeks, Monica can you have a look at the ui-reviews requested by Cristian to Pau. 

If later Pau finds any issue, we can address it in a follow-up bug
Flags: needinfo?(monica.meika)
Comment on attachment 8532066 [details]
Github pull request

Great job Cristian! Small nits and ready to go! Thanks!
Attachment #8532066 - Flags: review?(borja.bugzilla) → review+
(Assignee)

Comment 8

3 years ago
Thanks Borja, comments addressed
(Assignee)

Comment 9

3 years ago
As we explained to Monica offline, the gradient behind name and subject is not feasible because of performance (gradient + video). It was studied at the beginning of the project and it was removed from designs for that reason. Landing it as Maria Angeles suggested and we will address comments/changes like sizes, colors, etc.. if Pau see something wrong.

In master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/ffa96980a67192622546234a950d6002074ebc42
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 10

3 years ago
Comment on attachment 8532067 [details]
subject_call_screen_1.jpeg

I believe the subject is in the "light" version of the font and it should be in the "regular" one. Same font style.
Attachment #8532067 - Flags: ui-review?(b.pmm) → ui-review-
(Assignee)

Updated

3 years ago
Blocks: 1109067
(Assignee)

Comment 11

3 years ago
Comment on attachment 8532068 [details]
subject_call_screen_2.jpeg

same issue
Attachment #8532068 - Flags: ui-review?(b.pmm)
(Assignee)

Comment 12

3 years ago
Comment on attachment 8532069 [details]
subject_call_screen_3.jpeg

same issue
Attachment #8532069 - Flags: ui-review?(b.pmm)
(Assignee)

Comment 13

3 years ago
Comment on attachment 8532070 [details]
subject_call_screen_4.jpeg

same issue
Attachment #8532070 - Flags: ui-review?(b.pmm)
Flags: needinfo?(monica.meika)
You need to log in before you can comment on or make changes to this bug.