Closed
Bug 1097686
Opened 10 years ago
Closed 10 years ago
Show subject if exists in the outgoing/incoming call
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
Attachments
(5 files)
Updated•10 years ago
|
OS: All → Gonk (Firefox OS)
Hardware: All → ARM
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Summary: Show subject if exists in the outgoing call → Show subject if exists in the outgoing/incoming call
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8532066 -
Flags: review?(borja.bugzilla)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8532067 -
Flags: ui-review?(b.pmm)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8532068 -
Flags: ui-review?(b.pmm)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8532069 -
Flags: ui-review?(b.pmm)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8532070 -
Flags: ui-review?(b.pmm)
Comment 6•10 years ago
|
||
As Pau in on PTO and we are really in a hurry to land everything in the next two weeks, Monica can you have a look at the ui-reviews requested by Cristian to Pau. If later Pau finds any issue, we can address it in a follow-up bug
Flags: needinfo?(monica.meika)
Comment 7•10 years ago
|
||
Comment on attachment 8532066 [details]
Github pull request
Great job Cristian! Small nits and ready to go! Thanks!
Attachment #8532066 -
Flags: review?(borja.bugzilla) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Thanks Borja, comments addressed
Assignee | ||
Comment 9•10 years ago
|
||
As we explained to Monica offline, the gradient behind name and subject is not feasible because of performance (gradient + video). It was studied at the beginning of the project and it was removed from designs for that reason. Landing it as Maria Angeles suggested and we will address comments/changes like sizes, colors, etc.. if Pau see something wrong. In master: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/ffa96980a67192622546234a950d6002074ebc42
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 10•10 years ago
|
||
Comment on attachment 8532067 [details]
subject_call_screen_1.jpeg
I believe the subject is in the "light" version of the font and it should be in the "regular" one. Same font style.
Attachment #8532067 -
Flags: ui-review?(b.pmm) → ui-review-
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8532068 [details]
subject_call_screen_2.jpeg
same issue
Attachment #8532068 -
Flags: ui-review?(b.pmm)
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8532069 [details]
subject_call_screen_3.jpeg
same issue
Attachment #8532069 -
Flags: ui-review?(b.pmm)
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8532070 [details]
subject_call_screen_4.jpeg
same issue
Attachment #8532070 -
Flags: ui-review?(b.pmm)
Updated•10 years ago
|
Flags: needinfo?(monica.meika)
You need to log in
before you can comment on or make changes to this bug.
Description
•