1097692 - Error handling. We need to shield our code against errors when joining a room.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Borja Salguero [:borjasalguero]]

We need to handle errors related with the room (if there is no connectivity, if the room is full...)

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

We tried to take care of any fail on bug 1104003 anyway I take this bug and double check whether there is still something missing.

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/377

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8533751 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/377

Current patch takes care of several errors such as connectivity and server ones. Moreover it gives a try to resolve the 'room full' error by removing the user joining the room if she/he was already joined. Would you mind to have a look please? Thanks!

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8533751 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/377

From code point of view lgtm, thanks a lot, left a couple of messages

Comment 5

[Borja Salguero [:borjasalguero]]

Comment on attachment 8533751 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/377

It's more than enough with one reviewer, so let's merge this!

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/fde35b842285fae82f130809ed851776daf3fd4e