Closed
Bug 1097743
Opened 10 years ago
Closed 10 years ago
Standalone rooms needs Logo, ToS and additional styling
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox35 fixed, firefox36 fixed)
backlog | Fx35+ |
People
(Reporter: standard8, Unassigned)
References
Details
(Whiteboard: [rooms])
Attachments
(2 files, 1 obsolete file)
708.62 KB,
image/png
|
Details | |
12.87 KB,
patch
|
standard8
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We need to complete the layout of the standalone rooms views:
- Add the Logo
- Add the ToS links and Mozilla Logo
- Additional styling to make them work nicer, e.g. black background, and better resizing.
Reporter | ||
Comment 1•10 years ago
|
||
Darrin: Have we got the logo already? How do we get the standalone one for rooms?
Flags: needinfo?(dhenein)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nperriault
Points: --- → 5
Assignee | ||
Updated•10 years ago
|
Whiteboard: tech-debt
Assignee | ||
Updated•10 years ago
|
Whiteboard: tech-debt
Assignee | ||
Comment 2•10 years ago
|
||
Ready for review.
Part 2 will (try to) address remaining responsive design issues.
Attachment #8522415 -
Flags: review?(standard8)
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Removed dead code.
Attachment #8522415 -
Attachment is obsolete: true
Attachment #8522415 -
Flags: review?(standard8)
Attachment #8522421 -
Flags: review?(standard8)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8522421 [details] [diff] [review]
Part 1: Loop standalone styling enhancements.
Review of attachment 8522421 [details] [diff] [review]:
-----------------------------------------------------------------
r+ with the css issue fixed or explained.
::: browser/components/loop/content/shared/css/conversation.css
@@ +718,5 @@
> + background-position: 10px;
> + background-repeat: no-repeat;
> +}
> +
> +.room-conversation-wrapper header h1 .logo {
This style appears to be unused (some of its a duplicate of the previous one, so I think we can safely drop this).
Attachment #8522421 -
Flags: review?(standard8) → review+
Reporter | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/100301b84f5f
Dropping need-info as we've used the Firefox logo, which we understand is the correct one.
Marking as leave-open for the responsive design/general css improvements.
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Comment 9•10 years ago
|
||
I'm not sure if this is the best bug to handle this, but the standalone is currently missing a "rejoin" button. Doing a needinfo to Mark in case he is planning to do that on a different bug or wants me to file a new bug.
Flags: needinfo?(standard8)
Reporter | ||
Comment 10•10 years ago
|
||
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #9)
> I'm not sure if this is the best bug to handle this, but the standalone is
> currently missing a "rejoin" button. Doing a needinfo to Mark in case he is
> planning to do that on a different bug or wants me to file a new bug.
That would be bug 1100378.
Flags: needinfo?(standard8)
Updated•10 years ago
|
backlog: --- → Fx35+
Priority: -- → P1
Whiteboard: [rooms]
Assignee | ||
Comment 11•10 years ago
|
||
Filed bug 1104051 for remaining work here, so this can be marked as fixed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Keywords: leave-open
Comment 12•10 years ago
|
||
Bug 1104051 landed under this bug number, FWIW.
Comment 13•10 years ago
|
||
Comment on attachment 8522421 [details] [diff] [review]
Part 1: Loop standalone styling enhancements.
Approval Request Comment
[Feature/regressing bug #]: Rooms
[User impact if declined]: Merges (touches shared files, though it's standalone-only)
[Describe test coverage new/current, TBPL]: Standalone, NPOTB
[Risks and why]: virtually no risk (standalone changes to shared file)
[String/UUID change made/needed]: none
Attachment #8522421 -
Flags: approval-mozilla-beta?
Attachment #8522421 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8522421 -
Flags: approval-mozilla-beta?
Attachment #8522421 -
Flags: approval-mozilla-beta+
Attachment #8522421 -
Flags: approval-mozilla-aurora?
Attachment #8522421 -
Flags: approval-mozilla-aurora+
Comment 14•10 years ago
|
||
Comment 15•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•