1097743 - Standalone rooms needs Logo, ToS and additional styling

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

We need to complete the layout of the standalone rooms views:

- Add the Logo
- Add the ToS links and Mozilla Logo
- Additional styling to make them work nicer, e.g. black background, and better resizing.

Comment 1

[Mark Banner (:standard8)]

Darrin: Have we got the logo already? How do we get the standalone one for rooms?

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Part 1: Loop standalone styling enhancements.

Ready for review.

Part 2 will (try to) address remaining responsive design issues.

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Screenshot of Standalone Room UI, Part 1

Comment 4

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Part 1: Loop standalone styling enhancements.

Removed dead code.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8522421 [details] [diff] [review]
Part 1: Loop standalone styling enhancements.

Review of attachment 8522421 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the css issue fixed or explained.

::: browser/components/loop/content/shared/css/conversation.css
@@ +718,5 @@
> +  background-position: 10px;
> +  background-repeat: no-repeat;
> +}
> +
> +.room-conversation-wrapper header h1 .logo {

This style appears to be unused (some of its a duplicate of the previous one, so I think we can safely drop this).

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/100301b84f5f

Dropping need-info as we've used the Firefox logo, which we understand is the correct one.

Marking as leave-open for the responsive design/general css improvements.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/100301b84f5f

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b92ec32f2344

Comment 9

[Maire Reavy [:mreavy]]

I'm not sure if this is the best bug to handle this, but the standalone is currently missing a "rejoin" button.  Doing a needinfo to Mark in case he is planning to do that on a different bug or wants me to file a new bug.

Comment 10

[Mark Banner (:standard8)]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #9)
> I'm not sure if this is the best bug to handle this, but the standalone is
> currently missing a "rejoin" button.  Doing a needinfo to Mark in case he is
> planning to do that on a different bug or wants me to file a new bug.

That would be bug 1100378.

Comment 11

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Filed bug 1104051 for remaining work here, so this can be marked as fixed.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Bug 1104051 landed under this bug number, FWIW.

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8522421 [details] [diff] [review]
Part 1: Loop standalone styling enhancements.

Approval Request Comment
[Feature/regressing bug #]: Rooms
[User impact if declined]: Merges (touches shared files, though it's standalone-only)

[Describe test coverage new/current, TBPL]: Standalone, NPOTB

[Risks and why]: virtually no risk (standalone changes to shared file)

[String/UUID change made/needed]: none

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7e859c2b666c

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5c8a00d30634