Closed Bug 1097746 Opened 5 years ago Closed 5 years ago

Standalone UI for link clickers needs to display a link to the SUMO page

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
2

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.3
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: standard8, Assigned: rgauthier)

References

()

Details

(Whiteboard: [rooms][good first verify])

Attachments

(1 file, 1 obsolete file)

The UX shows an icon for a link to help for the rooms views.

Darrin - do we have an icon for this already that you'd be comfortable using?
Flags: needinfo?(dhenein)
Summary: Add a link to help on the Standalone Rooms view → Standalone UI for link clickers needs to display a link to the SUMO page
Duplicate of this bug: 1059744
Deferring to Michael who has been handling the icons for Hello.
Flags: needinfo?(dhenein) → needinfo?(mmaslaney)
Assignee: nobody → rgauthier
This patch requires the server to add a new supportUrl config parameter.
Attachment #8525331 - Flags: review?(standard8)
backlog: --- → Fx35+
Priority: -- → P1
Whiteboard: [rooms]
Comment on attachment 8525331 [details] [diff] [review]
Add a link to Hello's SUMO page for standalone

Review of attachment 8525331 [details] [diff] [review]:
-----------------------------------------------------------------

This is looking great, I think there's just one minor change to have a different url for each type of call (call url vs room)

::: browser/components/loop/standalone/server.js
@@ +30,5 @@
>      "loop.config.legalWebsiteUrl = '/legal/terms';",
>      "loop.config.fxosApp = loop.config.fxosApp || {};",
>      "loop.config.fxosApp.name = 'Loop';",
> +    "loop.config.fxosApp.manifestUrl = 'http://fake-market.herokuapp.com/apps/packagedApp/manifest.webapp';",
> +    "loop.config.supportUrl = 'https://support.mozilla.org/kb/group-conversations-firefox-hello-webrtc';"

I think for the link clicker, we should use this url:

https://support.mozilla.org/kb/respond-firefox-hello-invitation-guest-mode

For rooms, use the one you've got.


Please can you also add the new values to Makefile.
Attachment #8525331 - Flags: review?(standard8) → review-
Clearing needinfo - we have the icon that we need.
Flags: needinfo?(mmaslaney)
Attachment #8525331 - Attachment is obsolete: true
Attachment #8526038 - Flags: review?(standard8)
Comment on attachment 8526038 [details] [diff] [review]
Add a link to Hello's SUMO page for standalone

Review of attachment 8526038 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Niko -- T0keshu would love a review for this.  He just needs one from either you or Standard8 (whoever gets to it first).  Thanks.
Attachment #8526038 - Flags: review?(nperriault)
Comment on attachment 8526038 [details] [diff] [review]
Add a link to Hello's SUMO page for standalone

Review of attachment 8526038 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just needs a license header for the svg file (or bug 1059756 to land first and this one not adding the file).

::: browser/components/loop/content/shared/img/svg/glyph-help-16x16.svg
@@ +1,1 @@
> +<?xml version="1.0" encoding="utf-8"?>

This should get a license header (see icons-16x16.svg for an example).
Attachment #8526038 - Flags: review?(standard8)
Attachment #8526038 - Flags: review?(nperriault)
Attachment #8526038 - Flags: review+
Comment on attachment 8526038 [details] [diff] [review]
Add a link to Hello's SUMO page for standalone

Review of attachment 8526038 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm I think we decided to move all icons into a single SVG file recently (icons-16x16.svg…)

Ref: https://wiki.mozilla.org/Loop/Desktop_%26_Standalon/Code_Style_%26_Structure
Attachment #8526038 - Flags: feedback-
(In reply to Nicolas Perriault (:NiKo`) — needinfo me if you need my attention from comment #9)
> Hmm I think we decided to move all icons into a single SVG file recently
> (icons-16x16.svg…)

I was aware of that, but having seen the desktop patch, and the fact that we've got separate files for the gear menu items already, it seemed better to keep that pattern for the menu, and combine the svg patches in one go - xref bug 1059756 comment 11.
(In reply to Mark Banner (:standard8) from comment #10)
> (In reply to Nicolas Perriault (:NiKo`) — needinfo me if you need my
> attention from comment #9)
> > Hmm I think we decided to move all icons into a single SVG file recently
> > (icons-16x16.svg…)
> 
> I was aware of that, but having seen the desktop patch, and the fact that
> we've got separate files for the gear menu items already, it seemed better
> to keep that pattern for the menu, and combine the svg patches in one go -
> xref bug 1059756 comment 11.

I took a look at combining the changes in one of the patches, and it didn't really make sense for the individual patch, given where we are. Therefore I split this out into bug 1103893.
https://hg.mozilla.org/integration/fx-team/rev/1aceaddc54d7
Iteration: --- → 36.3
Points: --- → 2
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/1aceaddc54d7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8526038 [details] [diff] [review]
Add a link to Hello's SUMO page for standalone

Approval Request Comment
[Feature/regressing bug #]: N/A
[Risks and why]: No risk - Only affects standalone - NPOTB - eases other uplifts that touch both.
[String/UUID change made/needed]: none
Attachment #8526038 - Flags: approval-mozilla-aurora?
Attachment #8526038 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify-
Flags: in-moztrap-
Whiteboard: [rooms] → [rooms][good first verify]
You need to log in before you can comment on or make changes to this bug.