1097749 - Standalone rooms should display the room name

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

As part of the UX we should be displaying the room name. We can only get this after joining, via a GET /rooms/{token} on the server.

Comment 1

[Mark Banner (:standard8)]

Attachment: Standalone rooms should display the room name once the room has been joined.

Currently, until the server fixes and deploys bug 1103331, we can only display the room name after join. This does the necessary work to make that happen.

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8528376 [details] [diff] [review]
Standalone rooms should display the room name once the room has been joined.

Review of attachment 8528376 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, works great: ship it! (optional nits you might want to address)

::: browser/components/loop/content/shared/js/activeRoomStore.js
@@ +296,5 @@
> +
> +      // If we haven't got a room name yet, go and get one. We typically
> +      // need to do this in the case of the standalone window.
> +      // XXX When bug 1103331 lands this can be moved to earlier.
> +      if (!this.getStoreState().roomName) {

Nit: this._storeState.roomName is probably just fine here.

@@ +302,5 @@
> +          function(err, result) {
> +            if (err) {
> +              console.error("Failed to get room data:", err);
> +              return;
> +            }

Note: We'd usually want to dispatch an action here, but it's probably okay as we're only logging.

::: browser/components/loop/standalone/content/js/standaloneMozLoop.js
@@ +94,5 @@
> +          // We currently only require the roomName in the response.
> +          callback(null, validate(responseData, {
> +            roomName: String,
> +            roomOwner: String,
> +            roomUrl: String

Nit: This definition seems to contradict the comment above.

Comment 3

[Mark Banner (:standard8)]

Attachment: Standalone rooms should display the room name once the room has been joined.

Updated patch for review comments.

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/562e47b962ed

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/562e47b962ed

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8528622 [details] [diff] [review]
Standalone rooms should display the room name once the room has been joined.

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: Merge issues on the one shared file

[Describe test coverage new/current, TBPL]: Includes tests

[Risks and why]: Standalone changes; touches one file that's shared.  Very low risk, totally to rooms.

[String/UUID change made/needed]: none.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8528622 [details] [diff] [review]
Standalone rooms should display the room name once the room has been joined.

Approval Request Comment
Move request to beta

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/af06436c80ef