Remove checkin-needed keyword immediately when integrating a pull request

RESOLVED FIXED in 2.1 S9 (21Nov)

Status

Firefox OS
Gaia::GithubBot
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

(Blocks: 1 bug)

unspecified
2.1 S9 (21Nov)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently we wait until integration is complete before removing the keyword. Removing this immediately as we begin the landing process would cause less confusion as we transition to autolander.
(Assignee)

Updated

3 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED

Comment 1

3 years ago
Created attachment 8524534 [details] [review]
[PullReq] KevinGrandon:bug_1097751_checkin_needed_removal to KevinGrandon:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8524534 [details] [review]
[PullReq] KevinGrandon:bug_1097751_checkin_needed_removal to KevinGrandon:master

All tests passing and this is a minor change, so r=me.
Attachment #8524534 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S9 (21Nov)

Comment 3

3 years ago
Pull request has landed in master: https://github.com/KevinGrandon/autolander/commit/d01235c380d7ddf25550ecbe424ba809959df241

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.