Closed Bug 1097751 Opened 10 years ago Closed 10 years ago

Remove checkin-needed keyword immediately when integrating a pull request

Categories

(Firefox OS Graveyard :: Gaia::GithubBot, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::GithubBot
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S9 (21Nov)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[PullReq] KevinGrandon:bug_1097751_checkin_needed_removal to KevinGrandon:master
50 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
Currently we wait until integration is complete before removing the keyword. Removing this immediately as we begin the landing process would cause less confusion as we transition to autolander.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Comment on attachment 8524534 [details] [review]
[PullReq] KevinGrandon:bug_1097751_checkin_needed_removal to KevinGrandon:master

All tests passing and this is a minor change, so r=me.
Attachment #8524534 - Flags: review+
Keywords: checkin-needed
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S9 (21Nov)
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: