Closed
Bug 1097792
Opened 10 years ago
Closed 10 years ago
Further Tweak fling curving prefs
Categories
(Firefox OS Graveyard :: General, defect)
Firefox OS Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S2 (19dec)
People
(Reporter: mchang, Assigned: mchang)
References
Details
Attachments
(1 file)
1.24 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1095727 +++ Tweak the prefs set in bug 1095727 some more.
Assignee | ||
Comment 1•10 years ago
|
||
From bug 1095727, those settings are pretty good. It feels really nice. At this point I think either way, we're good and now it's personal preference. user_pref("apz.fling_curve_function_x1", ".385"); user_pref("apz.fling_curve_function_x2", ".76"); user_pref("apz.fling_curve_function_y1", "0"); user_pref("apz.fling_curve_function_y2", "1"); user_pref("apz.fling_curve_threshold_inches_per_ms", "0.01"); user_pref("apz.fling_friction", "0.00238"); The only things I wanted to change were: 1) Tweak the curve so that we get the speed bump just a tad earlier while maintaining the feel at low speeds. I noticed that whenever I wanted to go fast, I had to be much more intentional about it with the settings from 1095727. 2) Tweak the friction - I just wanted a tad more speed and more driftiness. This also janks a bit less during the final drift. @Gordon - Can you try these. Otherwise, the prefs in bug 1095727 can stand until silk comes around. Thanks!
Flags: needinfo?(gbrander)
Comment 2•10 years ago
|
||
While I do like the additional drifty-ness, I feel these prefs are too fast and feel less end-to-end consistent. One thing I want to avoid is a dramatic difference between the low and high-end. I think it's a usability win to maintain the illusion that scrolling only has one "mode".
Flags: needinfo?(gbrander)
Assignee | ||
Comment 3•10 years ago
|
||
From comment 2, closing.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Comment 4•10 years ago
|
||
I've got one more for you: user_pref("apz.fling_curve_function_x1", ".41"); user_pref("apz.fling_curve_function_y1", "0"); user_pref("apz.fling_curve_function_x2", ".8"); user_pref("apz.fling_curve_function_y2", "1"); user_pref("apz.fling_friction", "0.00238"); Drifty-er, but reduced at the high-end very slightly. I'm really happy with this one. Give it a spin.
Status: RESOLVED → REOPENED
Flags: needinfo?(mchang)
Resolution: WORKSFORME → ---
Assignee | ||
Comment 5•10 years ago
|
||
Just played with it. I like it! It feels much more predictable and scales better with fling speeds. I still think we need to tweak the low end a bit, but the low end here feels better than the low end from comment 1. And the top end speed is still a tad slow, but still good enough that I probably wouldn't notice it unless I look for it. And the extra drift, yummy!
Flags: needinfo?(mchang)
Assignee | ||
Comment 6•10 years ago
|
||
If you're happy with the prefs from comment 4, we can land it.
Attachment #8524098 -
Flags: review?(gbrander)
Comment 7•10 years ago
|
||
Gordon, do you want to land the prefs in comment 4?
Flags: needinfo?(gbrander)
Updated•10 years ago
|
Attachment #8524098 -
Flags: review?(gbrander) → review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Hi, could you provide a try run thanks!
Flags: needinfo?(mchang)
Keywords: checkin-needed
Comment 10•10 years ago
|
||
Not really worth doing a try run for this. I just landed it: https://hg.mozilla.org/integration/b2g-inbound/rev/08ad3521ebe6
Flags: needinfo?(mchang)
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/08ad3521ebe6
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S2 (19dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•