1097814 - Software buttons are broken in mulet and simulator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Simulator, defect)

Description

[Alexandre Poirot [:ochameau]]

Bug 1014418 most likely regressed these features. It looks like we need to send other kinds of events to gaia now (don't know yet what?).
We used to send mozChromeEvent to the system app.

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Hi Alexandre,

Did you mean software home buttons or software buttons you simulate in mulet and simulator?

If you mean the latter, this is because after bug 1014418 landed, system app no longer listens to mozChromeEvent.
Bug 989198 made KeyboardEvents dispatched across browser elements. System app now listens to KeyboardEvent and BeforeAfterKeyboardEvent introduced in bug 989198.

This page describe the whole scenario:   https://wiki.mozilla.org/WebAPI/BrowserAPI/KeyboardEvent#Dispatch_KeyboardEvent_across_BrowserElements

BeforeAfterKeyboardEvent is currently enabled in b2g only, with the pref 'dom.beforeAfterKeyboardEvent.enabled' set to true.

Comment 2

[Alexandre Poirot [:ochameau]]

(In reply to Tzu-Lin Huang [:dwi2][:tzhuang] from comment #1)
> Did you mean software home buttons or software buttons you simulate in mulet
> and simulator?

Yes, the ones in mulet, simulator and fx nightly mode.

Comment 3

[Alexandre Poirot [:ochameau]]

It's not really clear how we can implement software buttons now.
Before all these patches, pressing the HOME or END key of your keyboard was like pressing your home button and power button of your device.
Now it no longer works.

We used to send mozChromeEvent.
I tried dispatching fake KeyboardEvent and/or BeforeAfterKeyboardEvent, but nothing appear to work.
What precise kind of event should I dispatch on the system app to make it work??

Here is what I tried:
  let systemAppContentWindow;
  let KeyEvent = systemAppContentWindow.KeyEvent;
  var e = new systemAppContentWindow.KeyboardEvent("keydown", {keyCode: KeyEvent.DOM_VK_HOME});
  // Replacing KeyboardEvent with BeforeAfterKeyboardEvent doesn't change anything
  // Dispatching keydown, keyup or keypress doesn't work
  systemAppContentWindow.dispatchEvent(e); 

Or should I directly fake some mozbrowserbeforekeydown events?!

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Hi Alexandre, 

What you tried is almost right, except that you need to change {keyCode: KeyEvent.DOM_VK_HOME} to {key: 'Home'}. This is because we try to follow DOM level 3 definition.

Here is the key mapping:
  Home key: 'Home'
  Power key: 'Power'
  Volume up key: 'VolumeUp'
  Volume down key: 'VolumeDown'

I tried your code snippet with key definition above. And it works on mulet.

  let systemAppContentWindow;
  let KeyEvent = systemAppContentWindow.KeyEvent;
  var e = new systemAppContentWindow.KeyboardEvent("keydown", {key: "Home"});
  systemAppContentWindow.dispatchEvent(e); 

Also I press the HOME key on my physical keyboard when I use mulet, it also works.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: b2g desktop patch

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a9be118ddbad

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 8524143 [details] [diff] [review]
b2g desktop patch

Review of attachment 8524143 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/desktop.js
@@ +30,5 @@
>    // so that click events are delayed and it is better to
>    // listen for touch events.
>    homeButton.addEventListener('touchstart', function() {
> +    let window = shell.contentBrowser.contentWindow;
> +    let e = new window.KeyboardEvent("keydown", {key: "Home"});

As much as I prefer double quotes for strings, it looks like this file foolishly mixes quote style but uses single quotes in the functions touched by this patch.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: responsive design patch for mulet

I had to expose the system app frame from SystemAppProxy
in order to dispatch the KeyboardEvents... (instead of mozChromeEvent)

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: b2g desktop patch

Fixed quotes.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: b2g desktop patch

Really fix them...

Comment 10

[Alexandre Poirot [:ochameau]]

Checkin needed for attachment 8524567 [details] [diff] [review].

Comment 11

[Alexandre Poirot [:ochameau]]

Attachment: responsive design patch for mulet

No longer expose system app frame.
Exposes a helper on SystemAppProxy instead.

Comment 12

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f9e9b36e7aa6

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f1d347872c22

Comment 14

[Alexandre Poirot [:ochameau]]

Comment on attachment 8526178 [details] [diff] [review]
responsive design patch for mulet

Review of attachment 8526178 [details] [diff] [review]:
-----------------------------------------------------------------

Carry over review from paul and got offline r+ from vivien.

Comment 15

[Alexandre Poirot [:ochameau]]

Checking needed for the second patch.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/dcdd75b0017f

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dcdd75b0017f