Add search suggestions to the DuckDuckGo search engine

RESOLVED FIXED in seamonkey2.34

Status

enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: philip.chee, Assigned: philip.chee)

Tracking

Trunk
seamonkey2.34
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.34 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
DuckDuckGo supports search suggestions. We should enable this.
Assignee

Comment 1

5 years ago
Posted patch Patch v1.0 Proposed fix (obsolete) — Splinter Review
Add search suggestions to the duckduckgo search engine. Also update the ddg favicon.

The icon in our ddg search engine doesn't match the current ddg logo[2] so I've updated it[3] (I prefer the old icon actually)

[1] High resolution DDG Logos: https://onedrive.live.com/?cid=d38146e6f54d5475&id=D38146E6F54D5475!139&ithint=folder,.svg&authkey=!AGg0Aw4zd63lr3o
[2]http://www.google.com/images?q=duckduckgo+logo&hl=en&gbv=2&sa=X&oi=image_result_group
[3] From Bug 1061736 attachment 8503282 [details]
Attachment #8523043 - Flags: review?(iann_bugzilla)

Comment 2

5 years ago
Comment on attachment 8523043 [details] [diff] [review]
Patch v1.0 Proposed fix


> <Url type="text/html" method="GET" template="https://duckduckgo.com/">
>   <Param name="q" value="{searchTerms}"/>
>   <Param name="t" value="seamonkey"/>
> </Url>
>+<Url type="application/x-suggestions+json" method="GET" template="https://ac.duckduckgo.com/ac/">
>+  <Param name="q" value="{searchTerms}"/>
>+  <Param name="type" value="list"/>
>+</Url>
> <SearchForm>https://duckduckgo.com/</SearchForm>
> </SearchPlugin>
The typically format is for the suggestions to appear before the search engine entry.
<SearchForm> line could be removed and a rel="searchform" to the search engine entry, see Bug 1100670 for details.
As far as I can tell the icon is okay, but as Frank dealt with DuckDuckGo he might know more.
f=me for the moment as I'd like to see the new patch.
Flags: needinfo?(bugzilla)
Attachment #8523043 - Flags: review?(iann_bugzilla) → feedback+
Assignee

Comment 3

5 years ago
Changes since the last patch:
1. Moved search suggestions up.
2. Use rel="searchform" for the main search url/form

ui-r? for mcsmurf to review the ddg icon/branding.
Attachment #8523043 - Attachment is obsolete: true
Attachment #8526662 - Flags: ui-review?(bugzilla)
Attachment #8526662 - Flags: review?(iann_bugzilla)
Assignee

Comment 4

5 years ago
> ui-r? for mcsmurf to review the ddg icon/branding.

Comment 5

5 years ago
Comment on attachment 8526662 [details] [diff] [review]
Patch v2.0 fix review nits.

With rel="searchform" you should not have to use <SearchForm>, r=me with that addressed.
Attachment #8526662 - Flags: review?(iann_bugzilla) → review+
Assignee

Comment 6

5 years ago
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/9ffd9ba3edb0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.34
Comment on attachment 8526662 [details] [diff] [review]
Patch v2.0 fix review nits.

Looks good indeed... :)
Flags: needinfo?(bugzilla)
Attachment #8526662 - Flags: ui-review?(bugzilla) → ui-review+
You need to log in before you can comment on or make changes to this bug.