Closed Bug 1097818 Opened 9 years ago Closed 9 years ago

Add search suggestions to the DuckDuckGo search engine


(SeaMonkey :: Search, enhancement)

Not set


(seamonkey2.34 fixed)

Tracking Status
seamonkey2.34 --- fixed


(Reporter: philip.chee, Assigned: philip.chee)




(1 file, 1 obsolete file)

DuckDuckGo supports search suggestions. We should enable this.
Attached patch Patch v1.0 Proposed fix (obsolete) — Splinter Review
Add search suggestions to the duckduckgo search engine. Also update the ddg favicon.

The icon in our ddg search engine doesn't match the current ddg logo[2] so I've updated it[3] (I prefer the old icon actually)

[1] High resolution DDG Logos:!139&ithint=folder,.svg&authkey=!AGg0Aw4zd63lr3o
[3] From Bug 1061736 attachment 8503282 [details]
Attachment #8523043 - Flags: review?(iann_bugzilla)
Comment on attachment 8523043 [details] [diff] [review]
Patch v1.0 Proposed fix

> <Url type="text/html" method="GET" template="">
>   <Param name="q" value="{searchTerms}"/>
>   <Param name="t" value="seamonkey"/>
> </Url>
>+<Url type="application/x-suggestions+json" method="GET" template="">
>+  <Param name="q" value="{searchTerms}"/>
>+  <Param name="type" value="list"/>
> <SearchForm></SearchForm>
> </SearchPlugin>
The typically format is for the suggestions to appear before the search engine entry.
<SearchForm> line could be removed and a rel="searchform" to the search engine entry, see Bug 1100670 for details.
As far as I can tell the icon is okay, but as Frank dealt with DuckDuckGo he might know more.
f=me for the moment as I'd like to see the new patch.
Flags: needinfo?(bugzilla)
Attachment #8523043 - Flags: review?(iann_bugzilla) → feedback+
Changes since the last patch:
1. Moved search suggestions up.
2. Use rel="searchform" for the main search url/form

ui-r? for mcsmurf to review the ddg icon/branding.
Attachment #8523043 - Attachment is obsolete: true
Attachment #8526662 - Flags: ui-review?(bugzilla)
Attachment #8526662 - Flags: review?(iann_bugzilla)
> ui-r? for mcsmurf to review the ddg icon/branding.
Comment on attachment 8526662 [details] [diff] [review]
Patch v2.0 fix review nits.

With rel="searchform" you should not have to use <SearchForm>, r=me with that addressed.
Attachment #8526662 - Flags: review?(iann_bugzilla) → review+
Pushed to comm-central
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.34
Comment on attachment 8526662 [details] [diff] [review]
Patch v2.0 fix review nits.

Looks good indeed... :)
Flags: needinfo?(bugzilla)
Attachment #8526662 - Flags: ui-review?(bugzilla) → ui-review+
You need to log in before you can comment on or make changes to this bug.