1097818 - Add search suggestions to the DuckDuckGo search engine

Status: RESOLVED FIXED

(SeaMonkey :: Search, enhancement)

Description

[Philip Chee]

DuckDuckGo supports search suggestions. We should enable this.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix

Add search suggestions to the duckduckgo search engine. Also update the ddg favicon.

The icon in our ddg search engine doesn't match the current ddg logo[2] so I've updated it[3] (I prefer the old icon actually)

[1] High resolution DDG Logos: https://onedrive.live.com/?cid=d38146e6f54d5475&id=D38146E6F54D5475!139&ithint=folder,.svg&authkey=!AGg0Aw4zd63lr3o
[2]http://www.google.com/images?q=duckduckgo+logo&hl=en&gbv=2&sa=X&oi=image_result_group
[3] From Bug 1061736 attachment 8503282 [details]

Comment 2

[Ian Neal]

Comment on attachment 8523043 [details] [diff] [review]
Patch v1.0 Proposed fix


> <Url type="text/html" method="GET" template="https://duckduckgo.com/">
>   <Param name="q" value="{searchTerms}"/>
>   <Param name="t" value="seamonkey"/>
> </Url>
>+<Url type="application/x-suggestions+json" method="GET" template="https://ac.duckduckgo.com/ac/">
>+  <Param name="q" value="{searchTerms}"/>
>+  <Param name="type" value="list"/>
>+</Url>
> <SearchForm>https://duckduckgo.com/</SearchForm>
> </SearchPlugin>
The typically format is for the suggestions to appear before the search engine entry.
<SearchForm> line could be removed and a rel="searchform" to the search engine entry, see Bug 1100670 for details.
As far as I can tell the icon is okay, but as Frank dealt with DuckDuckGo he might know more.
f=me for the moment as I'd like to see the new patch.

Comment 3

[Philip Chee]

Attachment: Patch v2.0 fix review nits.

Changes since the last patch:
1. Moved search suggestions up.
2. Use rel="searchform" for the main search url/form

ui-r? for mcsmurf to review the ddg icon/branding.

Comment 4

[Philip Chee]

> ui-r? for mcsmurf to review the ddg icon/branding.

Comment 5

[Ian Neal]

Comment on attachment 8526662 [details] [diff] [review]
Patch v2.0 fix review nits.

With rel="searchform" you should not have to use <SearchForm>, r=me with that addressed.

Comment 6

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/9ffd9ba3edb0

Comment 7

[Frank Wein [:mcsmurf]]

Comment on attachment 8526662 [details] [diff] [review]
Patch v2.0 fix review nits.

Looks good indeed... :)