1097889 - [Settings] The user feedback textbox resets if the screen is locked

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Robert Mead [:RobertM]]

Attachment: Flame2.1logcat.txt

Description:
While submitting User Feedback, if text is entered into the textbox, then the device is locked, when it is unlocked, all the text in the textbox is cleared.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141112001201
2) Tap 'Settings' app
3) Scroll to the bottom and tap 'Improve Firefox OS'
4) Tap 'Send Mozilla Feeback' bar
5) Tap 'Happy' or 'Sad' (doesn't matter which one)
6) Tap the textbox and enter some text
7) Press the power button to lock the screen
8) Unlock the device and observe
  
Actual:
The text box is now blank
  
Expected: 
The text box still has the previously entered text


Flame 2.1(319mb)(KitKat)(Shallow Flash)  

Device: Flame 2.1
BuildID: 20141112001201
Gaia: 4c159e75a1568afbbf0c83c1235ec56facfbe87d
Gecko: b9849b3c6aaa
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

  
Repro frequency: 100%
See attached: logcat, video - http://youtu.be/QDIS5p8Q_S8

Comment 1

[Robert Mead [:RobertM]]

This issue also occurs on Flame 2.0(319mb) and Flame 2.2(319mb)

When submitting user feedback, if the user locks the device after entering text into the comment box, when the device is unlocked, all the text is cleared.


Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141112000204
Gaia: ab83632c92f9fc571b11d8468b6901cc4ed905c0
Gecko: 1ff99565be67
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Flame 2.2

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141112040208
Gaia: 5ae28ff11b982e2bd7d1aa097cda131536952bdc
Gecko: 688f821edcd4
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

Nominating to block 2.0. Locking the device/ the device falling asleep should never erase text that the user has input.

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch

Arthur, could you review the patch when you get a chance?

Thanks!

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8522756 [details] [review]
Proposed patch

Please check my comment in github, thanks.

Comment 5

[Wesly Huang (EPM)]

[Blocking Requested - why for this release]:

[Triage] Suggest nom. to 2.1 or 2.2 for consideration considering current timing of 2.0.

Comment 6

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8522756 [details] [review]
Proposed patch

Hey Arthur, I took into account your comments. Please review it

Thanks!

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8522756 [details] [review]
Proposed patch

The code looks good! Could you add a test ensuring that `keepAllInput` is called only when document is hidden?

Comment 8

[howie [:howie]]

Triage: Not blocking, low user impact.

Comment 9

[Manuel Casas Barrado [:mancas]]

Arthur, could you take a look at my comments in github? Thanks!

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Please check my response in github, thanks.

Comment 11

[Manuel Casas Barrado [:mancas]]

I've some problems with the unit tests, could you help me? I don't really know why the first test is working fine but not the second one.

Thanks

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

The reason is because `MockSendFeedback` returns a new instance every time you call to it. So `this.sendFeedback` is never be the same instance used in the panel. One way of fixing it would be make `MockSendFeedback` returns the same object.

Comment 13

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8522756 [details] [review]
Proposed patch

You're right! Now, you can review it when you get a chance

Thanks Arthur!

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8522756 [details] [review]
Proposed patch

We are almost there! Please check my comments, thanks.

Comment 15

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8522756 [details] [review]
Proposed patch

Hey Arthur, I took into account your comments. Please, take a look at the PR.

Thanks!

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8522756 [details] [review]
Proposed patch

r=me, thank you!

Comment 17

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/64ba456b8aadc35a51171dd5cde29eaf8d62b79f

Comment 18

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest nightly build of Flame v2.2 & Master by the STR in Comment 0.

Actual results: The text box still has the previously entered text after locking and unlocking screen.
See attachment: verified_Flame_v2.2.3gp
Reproduce rate: 0/10


Device: Flame v2.2 (Verified) 
Build ID               20150712002506
Gaia Revision          84d0c76370dcd3d25813b00de55194730884355b
Gaia Date              2015-07-09 13:09:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d59402ba85a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150712.040416
Firmware Date          Sun Jul 12 04:04:27 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master (Verified)
Build ID               20150712010205
Gaia Revision          e4b63559eba364892867eb381c3002d6518e5d6a
Gaia Date              2015-07-10 14:29:23
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eab21ec484bb
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150712.050401
Firmware Date          Sun Jul 12 05:04:12 EDT 2015
Bootloader             L1TC000118D0

Comment 19

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.2.3gp