sdk/test/assert input and output order does not match

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: evold, Assigned: evold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The sdk/test/assert input signatures are actual then expected, and the logged output is expected then actual.

For example, if I use `assert.equal(1, 2, "test")` the output will be `fail: test - 2 == 1`

this is very confusing in certain situations to me, and I think the order should be preserved.
Created attachment 8521619 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1710
Attachment #8521619 - Flags: review?(rFobic)
Assignee: nobody → evold
Note: discovered while working on bug 1097874
Priority: -- → P2
Attachment #8521619 - Flags: review?(rFobic) → review+

Comment 3

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/bab7ee1b6ad258f40820b5659dab80efab6ae371
Bug 1097918 - sdk/test/assert input and output order does not match

https://github.com/mozilla/addon-sdk/commit/4eec04c4585f73578e3ed37eb529846329cae3e3
Bug 1097918 - updating test-test-assert.js for the output changes

https://github.com/mozilla/addon-sdk/commit/e3d106cd78b30c8d98fd97cf349349c37e9987fa
Merge pull request #1710 from erikvold/1097918

Bug 1097918 - sdk/test/assert input and output order does not match r=gozala
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Blocks: 1114752
You need to log in before you can comment on or make changes to this bug.