Closed
Bug 1097926
Opened 10 years ago
Closed 10 years ago
Avoid calling isLoggable
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(1 file)
6.00 KB,
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
isLoggable is too expensive to have in-line in each log call. This patch converts some calls to used a cached value.
Attachment #8521627 -
Flags: review?(nalexander)
Comment 1•10 years ago
|
||
Comment on attachment 8521627 [details] [diff] [review] avoid-isloggable v0.1 Review of attachment 8521627 [details] [diff] [review]: ----------------------------------------------------------------- Sure.
Attachment #8521627 -
Flags: review?(nalexander) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d4fd43b50ba4
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d4fd43b50ba4
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•