Closed Bug 1097926 Opened 10 years ago Closed 10 years ago

Avoid calling isLoggable

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

isLoggable is too expensive to have in-line in each log call. This patch converts some calls to used a cached value.
Attachment #8521627 - Flags: review?(nalexander)
Comment on attachment 8521627 [details] [diff] [review]
avoid-isloggable v0.1

Review of attachment 8521627 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.
Attachment #8521627 - Flags: review?(nalexander) → review+
https://hg.mozilla.org/mozilla-central/rev/d4fd43b50ba4
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: