outgoing_links don't work properly on stage/-dev

VERIFIED FIXED in 2014-11-18

Status

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: cvan, Assigned: cvan)

Tracking

2014-11-18
Points:
---

Details

(URL)

(Assignee)

Description

4 years ago
1. Load https://marketplace.allizom.org/app/line or https://marketplace-dev.allizom.org/app/line (you should refresh once just in case, because I just updated the description).
2. Find the description and scroll to its bottom.
3. Find and hover over the "Go to download" link. Notice the URL starts with `https://outgoing.allizom.org/...` and `https://outgoing-mkt-dev.allizom.org/...`, respectively.
4. Load https://marketplace.firefox.com/app/line
5. Find the description and scroll to its bottom.
6. Find and hover over the "Go to download" link. Notice the URL is correct: `http://line.me/download`

Culprit:
https://github.com/mozilla/fireplace/blob/31db2d2/src/media/js/outgoing_links.js#L8

Conclusion:
This seems to always have worked correctly on prod, but I don't think this ever worked correctly on stage/-dev when the code was ported to Fireplace.
(Assignee)

Comment 1

4 years ago
Merged:
https://github.com/mozilla/fireplace/pull/792
https://github.com/mozilla/fireplace/commit/68be2dc
Assignee: nobody → cvan
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-11-18

Comment 2

4 years ago
Verified as fixed in FF36(Win7) in markeptplace-dev.allizom.org
Postfix screencast: http://screencast.com/t/4kA3jZRvLzJC
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.