Closed Bug 1098123 Opened 5 years ago Closed 5 years ago

Add telemetry for onbeforeunload usage

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: Dolske, Assigned: Dolske)

Details

Attachments

(1 file)

Attached patch Patch v.1Splinter Review
I am mildly curious as to (1) how often users see onbeforeunload prompts and (2) what they actually do when given the prompt. Yadda yadda, telemetry.

Simple patch, although after 20 minutes of searching I still can't find the apparently-undocumented magic trick to make about:telemetry work for a local build. *grumble* So I'm pretty sure this works, but I don't see the probes showing up there to verify it. :(

Handy testcase: http://dolske.net/mozilla/tests/prompt/onbeforeunload.html
Attachment #8521977 - Flags: review?(ehsan.akhgari)
Comment on attachment 8521977 [details] [diff] [review]
Patch v.1

Oops. Ehsan is PTO for a while. Let's try... *rolls 1d8* jst!
Attachment #8521977 - Flags: review?(ehsan.akhgari) → review?(jst)
Attachment #8521977 - Flags: review?(jst) → review+
Comment on attachment 8521977 [details] [diff] [review]
Patch v.1

Approval Request Comment
[Feature/regressing bug #]:

This is a pretty trivial patch to add a telemetry probe. I'd like to get it on Aurora to get to better real-world (release) data 6 weeks sooner.

[User impact if declined]: None
[Describe test coverage new/current, TBPL]: Should be covered by existing general tests, and was easy to verify with manual testing.
[Risks and why]: No specific risks.
[String/UUID change made/needed]: N/A
Attachment #8521977 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/5a0ffe8138d2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Attachment #8521977 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
A peek at the data so far...

On Nightly 36:

2.85K "Stay on Page", 22.75k "Leave Page", 7.23k prompt aborted. (Total 32.83k)
Or 9%, 69%, 22%.

On Aurora 35:

8.1k "Stay on Page", 55.42k "Leave Page", 11.68k prompt aborted. (Total 75.2k)
Or 11%, 74%, 16%.

I'm surprised by how high the prompt-aborted case is (meaning that while the prompt was showing, the user closed the tab instead of clicking a button).
Oh, and alas due to telemetry.mo not yet fully supporting the "count" probe type, we don't have useful reporting of how many prompts a user sees in a session. It just shows the grand total, instead of a histogram.
(In reply to Justin Dolske [:Dolske] from comment #6)
> A peek at the data so far...
> 
> On Nightly 36:
> 
> 2.85K "Stay on Page", 22.75k "Leave Page", 7.23k prompt aborted. (Total
> 32.83k)
> Or 9%, 69%, 22%.
> 
> On Aurora 35:
> 
> 8.1k "Stay on Page", 55.42k "Leave Page", 11.68k prompt aborted. (Total
> 75.2k)
> Or 11%, 74%, 16%.
> 
> I'm surprised by how high the prompt-aborted case is (meaning that while the
> prompt was showing, the user closed the tab instead of clicking a button).

Thinking about this, I guess it might have to do with people preferring to click UI that they are sure belongs to the browser (in-content dialogs are more easily spoofed).
You need to log in before you can comment on or make changes to this bug.