1098142 - [Settings] Cannot enter sub-panels after entering the more information panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

This issue was regressed by bug 1085290. It may require a module with an undefined path and leads to the following error:

[JavaScript Error: "TypeError: depMap is undefined" {file: "app://settings.gaiamobile.org/js/vendor/alameda.js" line: 1195}]

STR:
1. Launch settings app
2. Device Information -> More Information
3. Back to the root panel and try entering any of the panels.

Actual:
  Cannot enter the panels

Expected:
  Can enter the panels

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/26107

The root cause is that it tries to get an undefined property. In the patch I fixed it and also refactored it a bit. Unit tests were included.

EJ, would you mind review the patch? Thanks.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8522146 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/26107

This looks awesome ! r+ with one small nit on Github.

Thanks Arthur !

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ.

master: 1e300eac2e56d98ad51d414766d031db7d33221f