1098245 - Avoid cropping tab curve when selected tab is partially visible

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Lucas Rocha (:lucasr)]

Showing partially visible selected tab on the left is not a problem because it's the edge of the screen anyway. I'm not concerned about how it looks when the partially visible selected tab is displayed beside the "new tab" button.

Thoughts?

APK: https://dl.dropboxusercontent.com/u/1187037/snap-selected-tab.apk

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Feels good on my N9.

I think (although temporary) the overlap of the active tab and the dark background behind the + icon is weird.

Can we get some more fading there?

Comment 2

[Lucas Rocha (:lucasr)]

(In reply to Anthony Lam (:antlam) from comment #1)
> Feels good on my N9.
> 
> I think (although temporary) the overlap of the active tab and the dark
> background behind the + icon is weird.
> 
> Can we get some more fading there?

I had to disable the fading edge due to performance issue. Bug 1090364 got reopened as a result. I'll restore the fading edge with a new implementation.

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Avoid cropping tab curve when selected tab is partially visible (r=mcomella)

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8523843 [details] [diff] [review]
Avoid cropping tab curve when selected tab is partially visible (r=mcomella)

Review of attachment 8523843 [details] [diff] [review]:
-----------------------------------------------------------------

What is the motivation for this? To make the abrubtness of a selected tab under the + button stand out less?

I imagine this behavior could be slightly annoying (e.g. swiping left-to-right, looking for a tab on the left, finding it so releasing your finger, and having it get pushed off-screen to get the selected tab on-screen - most people aren't focused on the selected tab at this point and so it could be unintuitive).

I'm ambivalent about this change, but the implementation looks correct.

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Michael Comella (:mcomella) from comment #4)
> Comment on attachment 8523843 [details] [diff] [review]
> Avoid cropping tab curve when selected tab is partially visible (r=mcomella)
> 
> Review of attachment 8523843 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> What is the motivation for this? To make the abrubtness of a selected tab
> under the + button stand out less?
> 
> I imagine this behavior could be slightly annoying (e.g. swiping
> left-to-right, looking for a tab on the left, finding it so releasing your
> finger, and having it get pushed off-screen to get the selected tab
> on-screen - most people aren't focused on the selected tab at this point and
> so it could be unintuitive).
> 
> I'm ambivalent about this change, but the implementation looks correct.

Honestly, I'm mixed about it too. Let me first re-implement the fading edge to if it's enough. I'll put this patch on hold for now.

Comment 6

[Lucas Rocha (:lucasr)]

Anthony, I realize the shadow we have now is not ideal but I feel we shouldn't implement this behaviour. Do you feel strongly about this?

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

After speaking with :antlam, closing in favor of bug 1111820.