1098274 - [Stingray][Home] Add and remove card programitacally

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

This bug aims for:
1. Adding card through activities by other apps.
2. Removing card.

For 1, Since app deck hasn't been finished yet, for 1, I think we can just add card from home-app itself, but still going through activity, which can also be used by app deck. Therefore, we can change add-card feature easily to app deck after it's finished.

For 2, I think I would let the icon be deleted in context menu temporarily, until next spring we start implementing the editing mode.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Patch

Tzu-lin, are you available for reviewing this patch?

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Sure, I'll review it.

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8522182 [details] [review]
Patch

It looks good to me in general. But I left some comment on PR I'd like you to addressed before landing. 

Thanks

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Patch

I'm sorry that I made a mistake. I just found that the previous patch was for bug 1098162. I posted it wrongly here. But since dwi2 is also appropriate reviewer for that patch, I'll carry that r+ to 1098162.
Sorry for the confusing. And this is the right patch for solving this bug.
dwi2 would you mind review this patch again?

Comment 5

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8525139 [details] [review]
Patch

It looks good to me in general. Just some nits. I left them on PR.

Also, there might be some conflicts due to bug 1094091, you might need to rebase and resolve them before landing this patch.

Thanks.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://github.com/mozilla-b2g/gaia/commit/fa8ffc7293fd5deeb5c9597b9310a7aaea298e83