Closed Bug 1098274 Opened 6 years ago Closed 6 years ago

[Stingray][Home] Add and remove card programitacally

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S9 (21Nov)

People

(Reporter: rexboy, Assigned: rexboy)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file, 1 obsolete file)

46 bytes, text/x-github-pull-request
dwi2
: review+
Details | Review
This bug aims for:
1. Adding card through activities by other apps.
2. Removing card.

For 1, Since app deck hasn't been finished yet, for 1, I think we can just add card from home-app itself, but still going through activity, which can also be used by app deck. Therefore, we can change add-card feature easily to app deck after it's finished.

For 2, I think I would let the icon be deleted in context menu temporarily, until next spring we start implementing the editing mode.
Depends on: 1098162
Attached file Patch (obsolete) —
Tzu-lin, are you available for reviewing this patch?
Attachment #8522182 - Flags: review?(tzhuang)
Sure, I'll review it.
Comment on attachment 8522182 [details] [review]
Patch

It looks good to me in general. But I left some comment on PR I'd like you to addressed before landing. 

Thanks
Attachment #8522182 - Flags: review?(tzhuang) → review+
Assignee: nobody → rexboy
Attached file Patch
I'm sorry that I made a mistake. I just found that the previous patch was for bug 1098162. I posted it wrongly here. But since dwi2 is also appropriate reviewer for that patch, I'll carry that r+ to 1098162.
Sorry for the confusing. And this is the right patch for solving this bug.
dwi2 would you mind review this patch again?
Attachment #8525139 - Flags: review?(tzhuang)
Attachment #8522182 - Attachment is obsolete: true
Comment on attachment 8525139 [details] [review]
Patch

It looks good to me in general. Just some nits. I left them on PR.

Also, there might be some conflicts due to bug 1094091, you might need to rebase and resolve them before landing this patch.

Thanks.
Attachment #8525139 - Flags: review?(tzhuang) → review+
Target Milestone: --- → 2.1 S9 (21Nov)
https://github.com/mozilla-b2g/gaia/commit/fa8ffc7293fd5deeb5c9597b9310a7aaea298e83
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.