Closed Bug 1098296 Opened 9 years ago Closed 8 years ago

addLivemark should take a dateAdded input property

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36
Iteration:
37.1

People

(Reporter: asaf, Assigned: asaf)

References

Details

Attachments

(1 file)

patch
11.89 KB, patch
mak
: review+
Details | Diff | Splinter Review 
See my comment about NewLivemark in bug 1095425.
Attached patch patch — — Splinter Review 
Assignee: nobody → mano
Status: NEW → ASSIGNED

        Attachment #8527633 -
        Flags: review?(mak77)

    
  
Iteration: --- → 36.3
Points: --- → 3
Flags: qe-verify-

    
  
Flags: firefox-backlog+
Iteration: 36.3 → 37.1

    
    

    
  
Comment on attachment 8527633 [details] [diff] [review]
patch

Review of attachment 8527633 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/nsLivemarkService.js
@@ +426,5 @@
>    onItemChanged: function LS_onItemChanged(aItemId, aProperty, aIsAnno, aValue,
>                                             aLastModified, aItemType)
>    {
>      if (aItemType == Ci.nsINavBookmarksService.TYPE_FOLDER) {
> +      if (aLastModified != 0 &&

please fix the bookmarks idl instead, we never pass zero as lastModified, so you can restore most of the old code

@@ +438,5 @@
> +        else if (aProperty == "dateAdded") {
> +          this._livemark[aItemId].dateAdded = parseInt(aValue, 10);
> +        }
> +
> +        if (aLastModified != 0)

ditto

        Attachment #8527633 -
        Flags: review?(mak77) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3e39b5ca01ee
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36

          You need to log in
          before you can comment on or make changes to this bug.