Closed Bug 1098355 Opened 5 years ago Closed 5 years ago

Loop shared.utils.Helper should be a globaly available utility

Categories

(Hello (Loop) :: Client, defect, P4)

defect
Points:
2

Tracking

(firefox38 fixed)

RESOLVED FIXED
mozilla38
Iteration:
38.2 - 9 Feb
Tracking Status
firefox38 --- fixed
Blocking Flags:
backlog tech-debt

People

(Reporter: NiKo, Assigned: standard8)

References

Details

(Whiteboard: tech-debt)

Attachments

(1 file)

It's painful to pass it as props down the component tree.
backlog: --- → Fx37?
backlog: Fx37? → Fx38?
backlog: Fx38? → tech-debt
Priority: -- → P4
A lot of this is search/replace of the existing functions. I choose to pass down the isFirefox to the PromoteFirefoxView as this seems to fit better with the "only state or props determine the layout" that we have with react - calling the global direct feels like its hiding optional functionality.

I think it'll also fit better on the next patch I'm planning on doing for bug 1045495 (which is why I'm tidying this up a bit now).
Attachment #8559155 - Flags: review?(mdeboer)
Assignee: nobody → standard8
Blocks: 1045495
Iteration: --- → 38.2 - 9 Feb
Points: --- → 2
Comment on attachment 8559155 [details] [diff] [review]
Change the functions in Loop's shared.utils.Helper to be accessible from the global state and avoid passing the helper down through the component props tree.

Review of attachment 8559155 [details] [diff] [review]:
-----------------------------------------------------------------

<3 this simplification! Thanks, Niko, for filing this and Mark for fixing.
Attachment #8559155 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/127a5702f246
Target Milestone: --- → mozilla38
https://hg.mozilla.org/mozilla-central/rev/127a5702f246
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.