connect detection of features for WMW and Hello to buchets when submitting an app

VERIFIED FIXED in 2014-12-02

Status

P2
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: ddurst, Assigned: mat)

Tracking

(Blocks: 1 bug)

2014-12-02
Points:
---

Details

WMW and Hello require navigator.getMobileIdAssertion and the asm.js precompile manifest permission.

We need to hook these up to buchets when a developer is submitting an app so that those features' checkboxes are checked by default if an app uses them.
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Fixed in https://github.com/mozilla/app-validator/commit/4d1670b7c3fdccda56d716ad5fc577b0535d3732 and https://github.com/mozilla/zamboni/commit/b6ddbc54673eb5dad14885097a72c42ce5eefd96

STR:
- Submit a packaged app app using "precompile": ["foo.js"] property in the manifest and using navigator.getMobileIdAssertion() in its javascript code.
- Verify that the features for "Mobile ID" and "Asm.js Precompilation" are pre-checked
- Double check that these features are not pre-checked when submitting a packaged app that doesn't do all that.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-11-25

Comment 2

4 years ago
I modified the manifest and javascript following the steps from above, but "Mobile ID" is still not checked
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 3

4 years ago
Fixed in https://github.com/mozilla/app-validator/commit/395e683a34bf63dd0dfca16d2cec92e73013a681 and https://github.com/mozilla/zamboni/commit/bcc8192b815cbaf12a676dd68a1a22ca5bff3c7a
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Target Milestone: 2014-11-25 → 2014-12-02

Comment 4

4 years ago
Verified as fixed : http://screencast.com/t/autHjYHUlbD
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.