Closed Bug 1098515 Opened 5 years ago Closed 5 years ago

[Usage][Tests] Prepare the ground for MarionetteJS integration tests

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: azasypkin, Assigned: azasypkin)

Details

(Whiteboard: [NaBfT])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
salva
: review+
gtorodelvalle
: feedback+
Details | Review
Usage app lacks of MarionetteJS integration tests and, taking into account upcoming SmartData feature work, it would be beneficial to have such tests.

In the scope of this bug I suppose that we'll create necessary mocks, MarionetteJS helpers + at least one simple integration test to serve as the reference for future tests.
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Whiteboard: [NaBfT]
Waiting for Treeherder before asking for review
Comment on attachment 8523702 [details] [review]
GitHub pull request URL

Hey Salvador,

Here is a very basic integration test + some infrastructure stuff to make writing tests in the future easier.

I don't have much knowledge about Usage\CostControl app yet, so it would be great to have your opinion on that!

Thanks!
Attachment #8523702 - Flags: review?(salva)
Comment on attachment 8523702 [details] [review]
GitHub pull request URL

I'm not used to integrate with Marionette Tests so I'm asking German for a second opinion.
Attachment #8523702 - Flags: feedback?(gtorodelvalle)
Comment on attachment 8523702 [details] [review]
GitHub pull request URL

It seems great to my. As almost totally n00b with practical Marionette, I'm leaving you a couple of questions on GitHub but you have my blessings here. Thank you!

(Let's wait for German's opinion before merging).
Attachment #8523702 - Flags: review?(salva) → review+
Comment on attachment 8523702 [details] [review]
GitHub pull request URL

Hi guys! Sorry for the delay but I was trying to run the tests which I have not been able to yet :( So, focusing just on the code and since Salva told me that he was able to successfully run the tests, I'll f+ ;) Thanks Oleg!
Attachment #8523702 - Flags: feedback?(gtorodelvalle) → feedback+
Thanks for review guys!

Treeherder is green, so landed.

Master: https://github.com/mozilla-b2g/gaia/commit/2f7318553e4571b7dccc8784042cae2925e1d9a3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.