Closed Bug 1098540 Opened 5 years ago Closed 5 years ago

Standalone room view - muting local video should display the default avatar image

Categories

(Hello (Loop) :: Client, defect, P2)

defect
Points:
2

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
37.1
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
Blocking Flags:
backlog Fx36+

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [rooms][standalone])

Attachments

(1 file)

Currently when we mute local video in the standalone rooms view, we're not showing the default avatar image.

We do, however show it for the remote video when that gets muted.
backlog: --- → Fx36+
Priority: -- → P2
Whiteboard: [rooms][standalone]
Must remember that video muted == audio-only. Not the other way around.
Attachment #8527927 - Flags: review?(nperriault)
Comment on attachment 8527927 [details] [diff] [review]
Muting local video should display the default avatar image in Loop Rooms.

Review of attachment 8527927 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense. r=me with a small test added to check that the proper class matching state is applied, as per discussed on IRC.
Attachment #8527927 - Flags: review?(nperriault) → review+
Landed with tests as requested:

https://hg.mozilla.org/integration/fx-team/rev/f78fbb1da23b
Assignee: nobody → standard8
Iteration: --- → 37.1
Points: --- → 2
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/f78fbb1da23b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Flags: qe-verify-
Flags: in-testsuite+
Comment on attachment 8527927 [details] [diff] [review]
Muting local video should display the default avatar image in Loop Rooms.

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: UI for muting not as nice/slightly confusing

[Describe test coverage new/current, TBPL]: manual testing

[Risks and why]: extremely low risk (see the diffs) - just changes how the "local-stream-audio" and "local-stream-video" booleans are set

[String/UUID change made/needed]: none
Attachment #8527927 - Flags: approval-mozilla-aurora?
Comment on attachment 8527927 [details] [diff] [review]
Muting local video should display the default avatar image in Loop Rooms.

Approval Request Comment
Transfer request to beta
Attachment #8527927 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Attachment #8527927 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.