1098551 - nsBidiPresUtils should use the "nsBidiLevel" typedef (instead of uint8_t) more consistently

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

nsBidiPresUtils represents bidi embedding-level as nsBidiLevel, which is a typdef for uint8_t.

There are a few stray spots where it uses uint8_t directly, though. Filing this bug on fixing those.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

This patch changes to capture the result of GetFrameEmbeddingLevel(frame) & aBpd->GetParaLevel() in a nsBidiLevel. This is the type that these functions return, per code-quotes below:

> 274   /**
> 275    * Get the bidi embedding level of the given (inline) frame.
> 276    */
> 277   static nsBidiLevel GetFrameEmbeddingLevel(nsIFrame* aFrame);
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsBidiPresUtils.h#274

and
> 54 struct BidiParagraphData {
[...]
> 165   nsBidiLevel GetParaLevel()
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsBidiPresUtils.cpp#165

(Again, this is a typedef for uint8_t, so it doesn't really matter, but better to be consistent.)

Comment 2

[Simon Montagu :smontagu]

Comment on attachment 8522479 [details] [diff] [review]
fix

Review of attachment 8522479 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!

Comment 3

[Daniel Holbert [:dholbert]]

Thanks! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/ee366f6b2d3e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ee366f6b2d3e