Closed
Bug 1098629
Opened 10 years ago
Closed 9 years ago
Support the retry button on the error bar in more cases
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox35 affected, firefox36 affected)
backlog | Fx38? |
People
(Reporter: MattN, Assigned: MattN)
References
Details
Attachments
(1 file, 1 obsolete file)
There are some more cases where we can add retry support which weren't added in bug 1074670. There are also some cases (e.g. network errors) where the button is hooked up but not shown because the 2nd bar isn't shown due to the lack of a details message. We can default to the following strings in those cases: generic_failure_no_reason2=Would you like to try again? retry_button=Retry
Flags: qe-verify+
Flags: in-testsuite?
Flags: firefox-backlog+
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
/r/609 - Bug 1098629 - WIP to support the retry button on the error bar in more cases. Pull down this commit: hg pull review -r 1a7a478e5eb7ecf124b61ed0332f0ae5b83d1844
Updated•10 years ago
|
backlog: Fx35? → Fx35+
Priority: -- → P2
Updated•10 years ago
|
Iteration: 36.3 → 37.1
Updated•9 years ago
|
backlog: Fx35+ → Fx37?
Priority: P2 → P1
Updated•9 years ago
|
Iteration: 37.1 → 37.2
Updated•9 years ago
|
backlog: Fx37? → Fx37+
Updated•9 years ago
|
Iteration: 37.2 → 37.3
Comment 4•9 years ago
|
||
moving to 38 based on time - can consider uplifting if done early/hits bar/low risk.
Comment 5•9 years ago
|
||
moving to 38 based on time (though will definitely land/uplift if it lands in 37.3)- can consider uplifting if done early/hits bar/low risk. if this lands earlier - definitely want to uplift. especially since the retry button can work now that some of Pkerrs patches are landing for push retries when server is down.
Comment 6•9 years ago
|
||
hi matt, you have a patch - will you be putting up for review in 38.1?
Flags: needinfo?(MattN+bmo)
Updated•9 years ago
|
Iteration: 37.3 - 12 Jan → 38.1 - 26 Jan
Assignee | ||
Updated•9 years ago
|
Attachment #8522571 -
Flags: review?(pkerr)
Assignee | ||
Comment 8•9 years ago
|
||
/r/609 - Bug 1098629 - Support the retry button on the error bar in more cases. r=pkerr Pull down this commit: hg pull review -r 7e3bd82f65dc0254851ede1bac5ed7277c0c31df
Assignee | ||
Comment 9•9 years ago
|
||
This still seems to work but I don't remember context of what else I was planning on doing in this bug. I would appreciate a thorough review as I have forgotten some context.
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 10•9 years ago
|
||
https://reviewboard.mozilla.org/r/607/#review1645 ::: browser/components/loop/MozLoopService.jsm (Diff revision 2) > + log.trace(); It seemed useful to always log the stack trace of when setError was called. This only logs when the LogLevel includes Trace.
Assignee | ||
Comment 11•9 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e455e2408b6
Updated•9 years ago
|
Attachment #8522571 -
Flags: review?(pkerr) → review+
Assignee | ||
Comment 12•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/01cc2ba4cb59
Flags: in-testsuite? → in-testsuite+
Whiteboard: [fixed-in-fx-team]
Comment 13•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/01cc2ba4cb59
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla38
Updated•9 years ago
|
Iteration: --- → 38.1 - 26 Jan
Comment 14•9 years ago
|
||
This seems to be covered to some extent by automated tests. Is manual testing also needed here?
Flags: needinfo?(MattN+bmo)
QA Contact: anthony.s.hughes
Assignee | ||
Comment 15•9 years ago
|
||
It would be good but it's probably hard to replicate various server/network issues that this affects.
Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 16•9 years ago
|
||
It looks like this didn't get uplifted since I stopped following Hello development. Shall I request uplift? It adds a "Retry" button on panel error bars in more cases which helps with intermittent network/server issues or when a session expires.
Flags: needinfo?(gavin.sharp)
Comment 17•9 years ago
|
||
I don't see a strong reason to uplift this, maybe RT feels differently.
Flags: needinfo?(gavin.sharp)
Assignee | ||
Comment 18•9 years ago
|
||
Attachment #8522571 -
Attachment is obsolete: true
Attachment #8618635 -
Flags: review+
Assignee | ||
Comment 19•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•