Closed Bug 1098629 Opened 5 years ago Closed 5 years ago

Support the retry button on the error bar in more cases

Categories

(Hello (Loop) :: Client, defect, P2)

defect
Points:
3

Tracking

(firefox35 affected, firefox36 affected)

RESOLVED FIXED
mozilla38
Iteration:
38.1 - 26 Jan
Tracking Status
firefox35 --- affected
firefox36 --- affected
Blocking Flags:
backlog Fx38?

People

(Reporter: MattN, Assigned: MattN)

References

Details

Attachments

(1 file, 1 obsolete file)

There are some more cases where we can add retry support which weren't added in bug 1074670. There are also some cases (e.g. network errors) where the button is hooked up but not shown because the 2nd bar isn't shown due to the lack of a details message. We can default to the following strings in those cases:

generic_failure_no_reason2=Would you like to try again?
retry_button=Retry
Flags: qe-verify+
Flags: in-testsuite?
Flags: firefox-backlog+
/r/609 - Bug 1098629 - WIP to support the retry button on the error bar in more cases.

Pull down this commit:

hg pull review -r 1a7a478e5eb7ecf124b61ed0332f0ae5b83d1844
backlog: Fx35? → Fx35+
Priority: -- → P2
Iteration: 36.3 → 37.1
backlog: Fx35+ → Fx37?
Priority: P2 → P1
Iteration: 37.1 → 37.2
backlog: Fx37? → Fx37+
Moving this to P2 based on our new priority definitions.
Priority: P1 → P2
Iteration: 37.2 → 37.3
moving to 38 based on time - can consider uplifting if done early/hits bar/low risk.
Blocks: 1100969
backlog: Fx37+ → Fx38?
See Also: → 1070230
moving to 38 based on time (though will definitely land/uplift if it lands in 37.3)- can consider uplifting if done early/hits bar/low risk.  if this lands earlier - definitely want to uplift.  especially since the retry button can work now that some of Pkerrs patches are landing for push retries when server is down.
hi matt, you have a patch - will you be putting up for review in 38.1?
Flags: needinfo?(MattN+bmo)
Iteration: 37.3 - 12 Jan → 38.1 - 26 Jan
To be tracked by Hello Team.
Iteration: 38.1 - 26 Jan → ---
/r/609 - Bug 1098629 - Support the retry button on the error bar in more cases. r=pkerr

Pull down this commit:

hg pull review -r 7e3bd82f65dc0254851ede1bac5ed7277c0c31df
This still seems to work but I don't remember context of what else I was planning on doing in this bug. I would appreciate a thorough review as I have forgotten some context.
Flags: needinfo?(MattN+bmo)
https://reviewboard.mozilla.org/r/607/#review1645

::: browser/components/loop/MozLoopService.jsm
(Diff revision 2)
> +    log.trace();

It seemed useful to always log the stack trace of when setError was called. This only logs when the LogLevel includes Trace.
Attachment #8522571 - Flags: review?(pkerr) → review+
https://hg.mozilla.org/integration/fx-team/rev/01cc2ba4cb59
Flags: in-testsuite? → in-testsuite+
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/01cc2ba4cb59
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla38
Iteration: --- → 38.1 - 26 Jan
This seems to be covered to some extent by automated tests. Is manual testing also needed here?
Flags: needinfo?(MattN+bmo)
QA Contact: anthony.s.hughes
It would be good but it's probably hard to replicate various server/network issues that this affects.
Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(MattN+bmo)
It looks like this didn't get uplifted since I stopped following Hello development. Shall I request uplift? It adds a "Retry" button on panel error bars in more cases which helps with intermittent network/server issues or when a session expires.
Flags: needinfo?(gavin.sharp)
I don't see a strong reason to uplift this, maybe RT feels differently.
Flags: needinfo?(gavin.sharp)
Attachment #8522571 - Attachment is obsolete: true
Attachment #8618635 - Flags: review+
You need to log in before you can comment on or make changes to this bug.