Closed Bug 1098652 Opened 5 years ago Closed 5 years ago

ImageLoader::OnStopFrame should be called when we get FRAME_COMPLETE, not LOAD_COMPLETE

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file)

No description provided.
Summary: ImageLoader::OnStopFrame should called when we get FRAME_COMPLETE, not LOAD_COMPLETE → ImageLoader::OnStopFrame should be called when we get FRAME_COMPLETE, not LOAD_COMPLETE
Here we go. I believe we concluded that Chrome displays the image as it comes in (i.e. it doesn't wait for the first frame to complete) and IE waits for the entire image to be downloaded. This patch continues what seems to have been the intent of the existing to code, which is to take the middle path of waiting for the first frame to completely decode.
Attachment #8522604 - Flags: review?(tnikkel)
Attachment #8522604 - Flags: review?(tnikkel) → review+
Thanks for the review! The failures on that try job all look to be from bug 1089880, but given that this change has some potential to cause unforeseen problems, here's another try job to be sure:

https://tbpl.mozilla.org/?tree=Try&rev=640a53726082
https://hg.mozilla.org/mozilla-central/rev/ed1316a1b6e5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.