Closed
Bug 1098652
Opened 10 years ago
Closed 10 years ago
ImageLoader::OnStopFrame should be called when we get FRAME_COMPLETE, not LOAD_COMPLETE
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: seth, Assigned: seth)
References
Details
Attachments
(1 file)
1.00 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•10 years ago
|
Summary: ImageLoader::OnStopFrame should called when we get FRAME_COMPLETE, not LOAD_COMPLETE → ImageLoader::OnStopFrame should be called when we get FRAME_COMPLETE, not LOAD_COMPLETE
Assignee | ||
Comment 1•10 years ago
|
||
Here we go. I believe we concluded that Chrome displays the image as it comes in (i.e. it doesn't wait for the first frame to complete) and IE waits for the entire image to be downloaded. This patch continues what seems to have been the intent of the existing to code, which is to take the middle path of waiting for the first frame to completely decode.
Attachment #8522604 -
Flags: review?(tnikkel)
Assignee | ||
Comment 2•10 years ago
|
||
Here's a try job: https://tbpl.mozilla.org/?tree=Try&rev=090dd6ea209f
Updated•10 years ago
|
Attachment #8522604 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Thanks for the review! The failures on that try job all look to be from bug 1089880, but given that this change has some potential to cause unforeseen problems, here's another try job to be sure: https://tbpl.mozilla.org/?tree=Try&rev=640a53726082
Assignee | ||
Comment 4•10 years ago
|
||
Try looks good! Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/ed1316a1b6e5
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ed1316a1b6e5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•