Closed
Bug 1098663
Opened 10 years ago
Closed 10 years ago
[Stingray][System] Rename System to Services
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Firefox OS Graveyard
Gaia::System
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
Details
Attachments
(1 file)
According to bug 1080905, we need to update the System object to other name to prevent the conflict of ES6 module
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → im
|
|
Assignee | |
Comment 1•10 years ago
|
||
Rex, This is the first patch to sync with phone's system. We need to rename the System to Service to prevent the conflict of ES6. Please review this patch.
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8523703 [details] [review] rename system to service Sorry, forget to set review flag.
Attachment #8523703 -
Flags: review?(rexboy)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Rex, I had revised the PR according to your concern. Please review it again.
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8523703 [details] [review] rename system to service Looks good to me.
Attachment #8523703 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
merged to master: https://github.com/mozilla-b2g/gaia/commit/da4a975bb4e50821b5a67e5aa3c5d150bce602aa gaia-try is almost green with one known error https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=4bf846a6e52d Bug 1101227 Intermittent test_system_notification_bar.py TestNotificationBar.test_notification_bar | AssertionError: 'TestNotificationBar_BODY' != u'
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•