Closed
Bug 1098677
Opened 10 years ago
Closed 10 years ago
During install use the precomplete file to determine files to uninstall instead of the uninstall.log
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
Firefox 36
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file, 3 obsolete files)
6.26 KB,
patch
|
bbondy
:
review+
lsblakk
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta-
lsblakk
:
approval-mozilla-esr31-
|
Details | Diff | Splinter Review |
This is a much better source for the files and directories and I recently noticed that new files aren't always being added to the uninstall.log possibly due to the numerous changes to app update especially with the addition of staging.
Assignee | ||
Comment 1•10 years ago
|
||
I'm removing the deletion of the distribution directory from the common code so removal can be optional. Since Thunderbird supports the distribution directory this change is necessary.
Attachment #8522644 -
Flags: review?(josiah)
Assignee | ||
Comment 2•10 years ago
|
||
removed-files is now listed in the precomplete file so it doesn't have to be handled separately.
Attachment #8522674 -
Flags: review?(netzen)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8522674 -
Attachment is obsolete: true
Attachment #8522674 -
Flags: review?(netzen)
Attachment #8522675 -
Flags: review?(netzen)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8522644 -
Attachment is obsolete: true
Attachment #8522644 -
Flags: review?(josiah)
Attachment #8522676 -
Flags: review?(josiah)
Updated•10 years ago
|
Attachment #8522675 -
Flags: review?(netzen) → review+
Updated•10 years ago
|
Attachment #8522676 -
Flags: review?(josiah) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Pushed to fx-team https://hg.mozilla.org/integration/fx-team/rev/63832cac8084
Target Milestone: --- → Firefox 36
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8522676 [details] [diff] [review] Thunderbird patch Moved Thunderbird patch to bug 1101237.
Attachment #8522676 -
Attachment is obsolete: true
Attachment #8522676 -
Flags: review+
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/63832cac8084
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
status-firefox33:
--- → wontfix
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → fixed
status-firefox37:
--- → unaffected
status-firefox-esr31:
--- → affected
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8522675 [details] [diff] [review] patch rev2 I would like to get this and dependent bugs landed for at least Firefox 35. [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: Files are not removed on install and files left behind can lead to problems with the install. User impact if declined: Files are not removed on install and files left behind can lead to problems with the install. Fix Landed on Version: Firefox 36 Risk to taking this patch (and alternatives if risky): Small. Worst case scenario is that files won't be removed on install. It has been tested thoroughly by myself and has been verified. String or UUID changes made by this patch: None
Attachment #8522675 -
Flags: approval-mozilla-esr31?
Attachment #8522675 -
Flags: approval-mozilla-beta?
Attachment #8522675 -
Flags: approval-mozilla-aurora?
Comment 9•9 years ago
|
||
Comment on attachment 8522675 [details] [diff] [review] patch rev2 It's too late for Firefox 34 and ESR 31.3. We can consider this change for Firefox 35 and ESR 31.4.
Attachment #8522675 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment 10•9 years ago
|
||
Comment on attachment 8522675 [details] [diff] [review] patch rev2 Taking this for Aurora (35). It doesn't meet ESR criteria and it's not clear there's much value here vs. waiting for 38.0ESR so unless there's a strong case for this from ESR deployers, let's wait.
Attachment #8522675 -
Flags: approval-mozilla-esr31?
Attachment #8522675 -
Flags: approval-mozilla-esr31-
Attachment #8522675 -
Flags: approval-mozilla-aurora?
Attachment #8522675 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•