1098684 - [Settings] Remove the "AP PIN connection" option from "Connect with WPS" menu.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

Please check the comment 48 of bug 834114.
We have to remove the "AP PIN connection" option from "Connect with WPS" menu.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/26129

Hi EJ, could you help review this simple patch? Thanks.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8522654 [details]
link to https://github.com/mozilla-b2g/gaia/pull/26129

Thanks Arthur ! r+

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ.

master: ff43ba2e1a76bba471c875cb369b7f9fd46ad9ab

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8522654 [details]
link to https://github.com/mozilla-b2g/gaia/pull/26129

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: Users will see a broken feature.
[Testing completed]: Manual tests were completed.
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

The UI should have been hidden but the patch never lands to master.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

v2.1: https://github.com/mozilla-b2g/gaia/commit/916c2131993954d30bd08464be940b7375f609f8
v2.0: https://github.com/mozilla-b2g/gaia/commit/626d4d11a8c7e55022c1f364abb72ea340e2f1e7

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/626d4d11a8c7e55022c1f364abb72ea340e2f1e7

Comment 7

[Shine(Leave from Mozilla)]

Attachment: screenshot

This issue has been verified successfully on Flame 2.0, 2.1, 2.2 and woodduck 2.0.
See attachment: 1098684_screenshot.png
Reproducing rate: 0/5
Woodduck2.0 build:
Gaia-Rev        87b23fa81c3b59f2ba24b84f7d686f4160d4e7cb
Gecko-Rev       d049d4ef127844121c9cf14d2e8ca91fd9045fcb
Build-ID        20141124050313
Version         32.0

Flame 2.0 build:
Gaia-Rev        124c2f85f1b956e9e8429dab5121de702a3bc197
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/6b59dd2837c1
Build-ID        20141123000206
Version         32.0

flame 2.1 build:
Gaia-Rev        afdfa629be209dd53a1b7b6d6c95eab7077ffcd9
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/dc3018cbdbe6
Build-ID        20141123001201
Version         34.0

FLame 2.2 build:
Gaia-Rev        c5bad6d78c5fe168e3bb894fc5cb70902c9b19b1
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/c9cfa9b91dea
Build-ID        20141123040209
Version         36.0a1