account signup page should allow auto-checking of "choose what to sync" checkbox for sync migration

RESOLVED FIXED

Status

Cloud Services
Server: Firefox Accounts
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: markh, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

1.54 KB, application/x-javascript
Details
(Reporter)

Description

3 years ago
When the migration process takes you to about:accounts to create a new account, there should be no checkbox "choose what to sync" as sync is already configured.

So we need some way (query param?) to ask the hosted version of this page to hide that element.
(Reporter)

Comment 1

3 years ago
As a counter-point to this, rnewman suggests we *do* offer the choice of "what to sync" during this process.  From IRC:

11:32 AM <•rnewman> I think the datatype elections will probably be part of setup
11:32 AM <markh> you mean the enabled state of engines?
11:32 AM <•rnewman> yeah
11:32 AM <•rnewman> but not blindly -- if any are false, offer the datatype chooser
11:33 AM <markh> why would Fxa cause the user to change their mind?
11:33 AM <•rnewman> reasoning: Sync f*cks them up, and a few million users will have add-on sync turned off
11:33 AM <markh> oh
11:33 AM <•rnewman> basically this is a "you had these, still want that?" opportunity
11:34 AM <markh> I'm surprised sync screws them by itself, but I shouldn't be :)
11:34 AM <•rnewman> https://bugzilla.mozilla.org/show_bug.cgi?id=692620

So basically he is suggesting we offer the choice of what to sync if anything is currently disabled, as it is possible things are disabled accidentally.

Even if we go that route, we probably still need to remove that "choose what to sync" option.

Ryan, thoughts?
Flags: needinfo?(rfeeley)
In the flow diagram, when the user select Upgrade, I had proposed that we “Import legacy sync settings: Email, choose what to sync state & selections".

More verbosely, what we're recommending is:

1. If the user was syncing all items, that "Choose what to sync" is shown, but unchecked.
2. If the user had previously (un)chosen something, the "Choose what to sync" would shown, but checked. The user would then be re-shown their sync selection upon email verification (that part was not shown in the diagram).
3. The user always has the choice to choose sync datatypes upon verification, or to choose not to choose sync datatypes upon verification. I don't think we should ever hide the "Choose what to sync" checkbox.
Flags: needinfo?(rfeeley)
(Reporter)

Comment 3

3 years ago
(In reply to Ryan Feeley from comment #2)
> 2. If the user had previously (un)chosen something, the "Choose what to
> sync" would shown, but checked. The user would then be re-shown their sync
> selection upon email verification (that part was not shown in the diagram).

Cool - IIUC, that's exactly what rnewman suggested :)  But that still means we need control over the default state of that checkbox.  Chris, are you able to help with that?  (ie, do we need a github item opened or some other magic etc?)
Flags: needinfo?(ckarlof)
Summary: account signup page should not offer "choose what to sync" during a sync migration → account signup page should allow auto-checking of "choose what to sync" checkbox for sync migration
https://github.com/mozilla/fxa-content-server/issues/1954
Flags: needinfo?(ckarlof)
This is has been fixed in version 0.28 of FxA, which will be deployed to production around Jan 12, 2015. 

PR: https://github.com/mozilla/fxa-content-server/pull/1962
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You can test this now against our "latest" dev environment (https://developer.mozilla.org/en-US/Firefox_Accounts#Latest_development_(updated_continuously_from_master)

I've attached a user.js file for configuring Fx Sync to use this environment.
Created attachment 8537948 [details]
user.js
Created attachment 8537996 [details]
user.js
Attachment #8537948 - Attachment is obsolete: true
(Reporter)

Updated

3 years ago
See Also: → bug 1119578
Created attachment 8759426 [details]
user.js

Updated user.js with all the current endpoints.
Attachment #8537996 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.