Closed
Bug 1098955
Opened 10 years ago
Closed 10 years ago
Remove usage of InputWindow._getDpx()
Categories
(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S9 (21Nov)
People
(Reporter: mnjul, Assigned: mnjul)
Details
(Whiteboard: [p=1])
Attachments
(1 file)
I added ._getDpx() in bug 1059683 such that we could have a mocked value for window.devicePixelRatio during unit tests. I think using Object.defineProperty() should suffice for the same ultimate purpose, so let's remove the proxy function.
|
Assignee | |
Comment 1•10 years ago
|
||
Tim, does the motivation and patch look good to you? Thanks!
Assignee: nobody → jlu
Attachment #8522709 -
Flags: review?(timdream)
|
||
Updated•10 years ago
|
Attachment #8522709 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Master it is in: https://github.com/mozilla-b2g/gaia/commit/1dd8ad8f96988afebc9691e1b818fa37aa32c790
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S9 (21Nov)
You need to log in
before you can comment on or make changes to this bug.
Description
•