1099041 - Add the manifest file that sets the default values as a dependency to the others

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Now that we can include a parent manifest with:
> [parent:../manifest.ini]

Let's include them in the manifest for accessibility, endurance, functional, unit. This would finally fix bug 1098279.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8522878 [details] [review]
Gaia PR

We should indicate the parent for all manifest files, not just the first level.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8522878 [details] [review]
Gaia PR

Changes made.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8522878 [details] [review]
Gaia PR

This looks great. If you can confirm that the default values from the child manifest files override the default values from the parent/top manifest then let's get this squashed and merged.

Comment 5

[Johan Lorenzo [:jlorenzo]]

With the PR applied:

> gaiatest ... gaiatest/tests/functional/dialer/manifest.ini --type=b2g+carrier
executes 11 tests,

> gaiatest ... gaiatest/tests/functional/dialer/manifest.ini --type=b2g-carrier
executes 0,

> gaiatest ... gaiatest/tests/functional/browser/manifest.ini --type=b2g-carrier
executes 8 (out of 9).

I think we can conclude that the child manifest correctly overrides the default values of the (grand)parent. The commits have been squashed.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR 2.1

Here's now the PR for 2.1.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/70216cf8e35a09a6b3303119f1046b938448814c

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8522930 [details] [review]
Gaia PR 2.1

Landed in v2.1:
https://github.com/mozilla-b2g/gaia/commit/e6409eb6d2e8c13127f9e6e46995db03354e4b57

Comment 9

[Zac C (:zac)]

Reverted the patch to v2.1 because it broke Gaia-Try against v2.1. The packages in the b2g34_v2.1 branch do not have the features/functionality that this branch demands.

You'll have to uplift the manifestparser to b2g34 or skip this testing for v2.1 branch.

https://github.com/mozilla-b2g/gaia/commit/29f0c4f7ced6cad33d2c326ccbb1b262fbd7bc80