Add the manifest file that sets the default values as a dependency to the others

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jlorenzo, Assigned: jlorenzo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Now that we can include a parent manifest with:
> [parent:../manifest.ini]

Let's include them in the manifest for accessibility, endurance, functional, unit. This would finally fix bug 1098279.
Created attachment 8522878 [details] [review]
Gaia PR
Attachment #8522878 - Flags: review?(zcampbell)
Attachment #8522878 - Flags: review?(florin.strugariu)
Attachment #8522878 - Flags: review?(dave.hunt)
Comment on attachment 8522878 [details] [review]
Gaia PR

We should indicate the parent for all manifest files, not just the first level.
Attachment #8522878 - Flags: review?(zcampbell)
Attachment #8522878 - Flags: review?(florin.strugariu)
Attachment #8522878 - Flags: review?(dave.hunt)
Attachment #8522878 - Flags: review-
Comment on attachment 8522878 [details] [review]
Gaia PR

Changes made.
Attachment #8522878 - Flags: review- → review?(dave.hunt)
Comment on attachment 8522878 [details] [review]
Gaia PR

This looks great. If you can confirm that the default values from the child manifest files override the default values from the parent/top manifest then let's get this squashed and merged.
Attachment #8522878 - Flags: review?(dave.hunt) → review+
With the PR applied:

> gaiatest ... gaiatest/tests/functional/dialer/manifest.ini --type=b2g+carrier
executes 11 tests,

> gaiatest ... gaiatest/tests/functional/dialer/manifest.ini --type=b2g-carrier
executes 0,

> gaiatest ... gaiatest/tests/functional/browser/manifest.ini --type=b2g-carrier
executes 8 (out of 9).

I think we can conclude that the child manifest correctly overrides the default values of the (grand)parent. The commits have been squashed.
Created attachment 8522930 [details] [review]
Gaia PR 2.1

Here's now the PR for 2.1.
Attachment #8522930 - Flags: review?(dave.hunt)
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
QA Whiteboard: [fxosqa-auto-s4+][fxosqa-auto-points=1]
Assignee: nobody → jlorenzo

Comment 9

4 years ago
Reverted the patch to v2.1 because it broke Gaia-Try against v2.1. The packages in the b2g34_v2.1 branch do not have the features/functionality that this branch demands.

You'll have to uplift the manifestparser to b2g34 or skip this testing for v2.1 branch.

https://github.com/mozilla-b2g/gaia/commit/29f0c4f7ced6cad33d2c326ccbb1b262fbd7bc80

Updated

4 years ago
Blocks: 1102560
Blocks: 1073048
You need to log in before you can comment on or make changes to this bug.