1099046 - Autocomplete popup displays "moz-action:searchengine,..." for keyword searches while pressing Shift

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Dão Gottwald [:dao]]

STR:
- add a keyword for a search engine
- type the keyword plus some search term in the location bar
- hit the down arrow key to select the autocomplete item for the keyword search
- press Shift

Comment 1

[Marco Bonardo [:mak]]

should be tested again after bug 1070778.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Not fixed by bug 1070778, so taking this now since it's enough to block shipping unifiedcomplete.

Comment 3

[Marco Mucci [:MarcoM]]

Hi Blair, can you provide a point value.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Oops

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Dependent on the changes in head.js done in bug 1073339.

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8529396 [details] [diff] [review]
Patch v1

Review of attachment 8529396 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure why but it doesn't seem to work for me, I tried a couple rebuilds but nothing..

when I move to a switch to tab entry and I press shift, the switch to tab text should be replaced by the url but that doesn't happen.

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1.1

Could you try again?

autocomplete.xml got bitrotten, am wondering if that was your issue. This patch is the same as the previous, just rebased.

Comment 8

[Marco Bonardo [:mak]]

Comment on attachment 8530821 [details] [diff] [review]
Patch v1.1

Review of attachment 8530821 [details] [diff] [review]:
-----------------------------------------------------------------

yeah now it works. sorry for the delay.

::: toolkit/content/widgets/autocomplete.xml
@@ +1608,5 @@
>              this.setAttribute("actiontype", action.type);
>  
>              if (action.type == "switchtab") {
> +            this.classList.add("overridable-action");
> +            displayUrl = action.params.url;

splinter doesn't show the right indentation here, please check.

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/f9d665c7c667

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f9d665c7c667

Comment 11

[08xjcec48]

This bug affects me on Firefox 48 for Linux.

Comment 12

[08xjcec48]

(for all keyword completions, not just when shift is pressed)

Comment 13

[Marco Bonardo [:mak]]

(In reply to Hide my Email from comment #11)
> This bug affects me on Firefox 48 for Linux.

please check in Safe mode, cause your issue may be caused by an add-on.
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Comment 14

[08xjcec48]

Ah, it's not exactly fault of an extension but some internal change of Firefox that broke keyword previews when the bookmark URL starts with a pseudo-protocol like private: .

I'm waiting for the new version of Private Tab to be reviewed to test if this still happens (https://addons.mozilla.org/firefox/addon/private-tab/versions/).