1099055 - Clicking on an anchor in a webpage makes title not pushed back to the statusbar

Status: VERIFIED FIXED

Description

[Alexandre LISSY :gerard-majax]

Scrolling in a web page pushed the title of the page inside the statusbar. But after clicking a link to an anchor on the same page, it does not work and title is "blocked" and not pushed to the statusbar when scrolling.

STR:
 0. Open Browser
 1. Browse to http://www.w3.org/TR/html401/struct/links.html
 2. Click on a link in the menu of the page

Expected:
 When I scroll, the title of the page is pushed to statusbar

Actual:
 Title stays big.

Comment 1

[Chris Lord [:cwiiis]]

Can reproduce - I suspect going to an anchor counts as a location-change, but we don't get a document size event after that.

We could solve this either by checking the size on scroll-change (probably a bad idea) or filtering out anchor changes... I'll do the latter.

I expect this affects 2.1... I don't suppose it's a blocker, but as I suspect the fix will be quite simple, I'll request when it's done.

Comment 2

[Chris Lord [:cwiiis]]

Created attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing

Comment 3

[Chris Lord [:cwiiis]]

Just a note; this can't easily be tested via marionette because scrollgrab doesn't work without apz (and thus the rocketbar can never be collapsed).

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing

Looking good! But we should cover this with a small unit test (we already have some around this [1]), making sure the containerElement keeps the "scrollable" class.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/unit/app_chrome_test.js#L201-220

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing

Stopped being lazy and added unit test :)

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing

Thanks!

Comment 7

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/fccfaa85efd7712a8d72905b0845a5d0290269d3

Comment 8

[Chris Lord [:cwiiis]]

Comment on attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Rocketbar will become permanently visible after navigating to an anchor on the same page, until the user navigates to another URL.
[User impact] if declined: Confusing behaviour after visiting an anchor on the same page (common in pages that have indices/appendices, but not perhaps that common in general mobile web browsing).
[Testing completed]: Tested locally, has unit test
[Risk to taking this patch] (and alternatives if risky): Low risk.
[String changes made]: None

This isn't a blocker and it's not the end of the world if we don't uplift this, but I believe it to be low risk and it's nice to fix bugs that can be so easily encountered.

Comment 9

[bhavana bajaj [:bajaj]]

Comment on attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing

Chris, was really on the fence for this one but given the test coverage and that the users will see this often, uplifting to avoid the annoyance :)

Comment 10

[Wes Kocher (:KWierso)]

https://github.com/mozilla-b2g/gaia/commit/f211a1b6cb136c944f2e7b17650ae4c541bd512f

Comment 11

[Lance（leave from Mozilla）]

Hi Alex,
Can you provide the bug video for me? Thanks.

Comment 12

[Alexandre LISSY :gerard-majax]

(In reply to Lance from comment #11)
> Hi Alex,
> Can you provide the bug video for me? Thanks.

No, why do you need a video ? STRs are not working for you ?

Comment 13

[Lance（leave from Mozilla）]

This issue has been verified successfully on Flame 2.1.
See attachment: 1059.MP4
Reproducing rate: 0/5

Step:
 1.Launch Browser.
 2.Browse to http://www.w3.org/TR/html401/struct/links.html.
 3.Slide the page, then tap a link in the menu of the page.
 4.Slide the page again.

Actual result:
When I scroll, the title of the page is pushed to statusbar.

Flame 2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880

Comment 14

[Lance（leave from Mozilla）]

Created attachment 8530722 [details]
1059.MP4