Closed
Bug 1099055
Opened 11 years ago
Closed 11 years ago
Clicking on an anchor in a webpage makes title not pushed back to the statusbar
Categories
(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)
Firefox OS Graveyard
Gaia::System::Browser Chrome
ARM
Gonk (Firefox OS)
Tracking
(b2g-v2.1 verified)
VERIFIED
FIXED
2.1 S9 (21Nov)
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | verified |
People
(Reporter: gerard-majax, Assigned: cwiiis)
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
46 bytes,
text/x-github-pull-request
|
etienne
:
review+
bajaj
:
approval-gaia-v2.1+
|
Details | Review |
2.80 MB,
video/mp4
|
Details |
Scrolling in a web page pushed the title of the page inside the statusbar. But after clicking a link to an anchor on the same page, it does not work and title is "blocked" and not pushed to the statusbar when scrolling.
STR:
0. Open Browser
1. Browse to http://www.w3.org/TR/html401/struct/links.html
2. Click on a link in the menu of the page
Expected:
When I scroll, the title of the page is pushed to statusbar
Actual:
Title stays big.
Flags: needinfo?(chrislord.net)
Assignee | ||
Comment 1•11 years ago
|
||
Can reproduce - I suspect going to an anchor counts as a location-change, but we don't get a document size event after that.
We could solve this either by checking the size on scroll-change (probably a bad idea) or filtering out anchor changes... I'll do the latter.
I expect this affects 2.1... I don't suppose it's a blocker, but as I suspect the fix will be quite simple, I'll request when it's done.
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
Flags: needinfo?(chrislord.net)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8523023 -
Flags: review?(etienne)
Assignee | ||
Comment 3•11 years ago
|
||
Just a note; this can't easily be tested via marionette because scrollgrab doesn't work without apz (and thus the rocketbar can never be collapsed).
Updated•11 years ago
|
Whiteboard: [systemsfe]
Comment 4•11 years ago
|
||
Comment on attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing
Looking good! But we should cover this with a small unit test (we already have some around this [1]), making sure the containerElement keeps the "scrollable" class.
[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/unit/app_chrome_test.js#L201-220
Attachment #8523023 -
Flags: review?(etienne)
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing
Stopped being lazy and added unit test :)
Attachment #8523023 -
Flags: review?(etienne)
Comment 6•11 years ago
|
||
Comment on attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing
Thanks!
Attachment #8523023 -
Flags: review?(etienne) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Rocketbar will become permanently visible after navigating to an anchor on the same page, until the user navigates to another URL.
[User impact] if declined: Confusing behaviour after visiting an anchor on the same page (common in pages that have indices/appendices, but not perhaps that common in general mobile web browsing).
[Testing completed]: Tested locally, has unit test
[Risk to taking this patch] (and alternatives if risky): Low risk.
[String changes made]: None
This isn't a blocker and it's not the end of the world if we don't uplift this, but I believe it to be low risk and it's nice to fix bugs that can be so easily encountered.
Attachment #8523023 -
Flags: approval-gaia-v2.1?
Updated•11 years ago
|
blocking-b2g: 2.2? → ---
Comment 9•11 years ago
|
||
Comment on attachment 8523023 [details] [review]
Fix anchor links breaking rocketbar collapsing
Chris, was really on the fence for this one but given the test coverage and that the users will see this often, uplifting to avoid the annoyance :)
Attachment #8523023 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
status-b2g-v2.1:
--- → fixed
Updated•11 years ago
|
Target Milestone: --- → 2.1 S9 (21Nov)
Comment 11•11 years ago
|
||
Hi Alex,
Can you provide the bug video for me? Thanks.
Flags: needinfo?(lissyx+mozillians)
Reporter | ||
Comment 12•11 years ago
|
||
(In reply to Lance from comment #11)
> Hi Alex,
> Can you provide the bug video for me? Thanks.
No, why do you need a video ? STRs are not working for you ?
Flags: needinfo?(lissyx+mozillians)
Comment 13•11 years ago
|
||
This issue has been verified successfully on Flame 2.1.
See attachment: 1059.MP4
Reproducing rate: 0/5
Step:
1.Launch Browser.
2.Browse to http://www.w3.org/TR/html401/struct/links.html.
3.Slide the page, then tap a link in the menu of the page.
4.Slide the page again.
Actual result:
When I scroll, the title of the page is pushed to statusbar.
Flame 2.1 version:
Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev https://hg.mozilla.org/releases/mozilla-2g34_v2_1/rev/18fb67530b22
Build-ID 20141130001203
Version 34.0
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20141130.034738
FW-Date Sun Nov 30 03:47:49 EST 2014
Bootloader L1TC00011880
Updated•11 years ago
|
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Comment 14•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•