1099061 - NodeInfobar shows different dimensions than "Box Model"

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Elbart]

Attachment: dimensions.png

Testcase: https://bug1064775.bugzilla.mozilla.org/attachment.cgi?id=8487618

"Box Model" says 404x31, hover says 404x32.

Comment 1

[Patrick Brosset <:pbro>]

The box model sidebar gets the content width/height from: http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/styles.js#569
The infobar gets it from: http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/highlighter.js#1162

So one rounds the values, the other ceils them.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Because pixels can be fractional we should always use Math.Ceil() e.g. 0.3px will be rendered as 1px.

Comment 3

[Kai Strecker [:kstrecker]]

Hi,

can i work on this bug please?

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Kai Strecker [:kstrecker] from comment #3)
> Hi,
> 
> can i work on this bug please?

Sure, I will assign it to you.

If you have any questions then you can ask in this bug or ping me in #devtools on irc.mozilla.org

Comment 5

[Kai Strecker [:kstrecker]]

Attachment: 1099061.patch

So, here is the patch. I hope that it is okay.

Comment 6

[Josh Matthews [:jdm]]

Thanks Kai! You'll want to follow the instructions at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed to make sure your changes get reviewed :)

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8526884 [details] [diff] [review]
1099061.patch

Review of attachment 8526884 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming that this fixes the problem then an easy r+.

Would you like me to land this?

Comment 8

[Kai Strecker [:kstrecker]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #7)

> Assuming that this fixes the problem then an easy r+.
Thank you for the review.

> Would you like me to land this?
Yes, this would be great. Thanks. :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/28be6b157ca4

Thanks for the patch, Kai! One request - for the future, we typically ask that the commit message be summarizing what the patch is doing rather than restating the problem it's fixing. Thanks!
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/28be6b157ca4