Implement new interface to allow users to select subject

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: frsela, Assigned: frsela)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In order to allow a user to change the conversation subject, new parameters will be added to the protocol.

This bug covers the interface using this new API with the Loop server
Assignee: nobody → frsela
Blocks: 1097685, 1097529
Depends on: 1095358
Created attachment 8523870 [details] [review]
Proposed patch (WIP)
Attachment #8523870 - Flags: feedback?(borja.bugzilla)
Attachment #8523870 - Flags: feedback?(borja.bugzilla) → feedback?(crdlc)
Comment on attachment 8523870 [details] [review]
Proposed patch (WIP)

LGTM, I left a comment, please take a look at github, thanks a lot
Attachment #8523870 - Flags: feedback?(crdlc) → feedback+
Comment on attachment 8523870 [details] [review]
Proposed patch (WIP)

The code looks great as a WIP. Let's remove the logs and get the final version of the patch and let us know! Great job! Gracias! ;)
Attachment #8523870 - Flags: feedback?(borja.bugzilla) → feedback+
Attachment #8523870 - Flags: review?(crdlc)
Attachment #8523870 - Flags: review?(borja.bugzilla)
Comment on attachment 8523870 [details] [review]
Proposed patch (WIP)

LGTM, left a comment about indentation in a line, the rest is perfect. Although you have to rebase the pr
Attachment #8523870 - Flags: review?(crdlc) → review+
Attachment #8523870 - Flags: review?(borja.bugzilla) → review+
Rebased & Landed: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/6c50b87a6ea77706087cfc209838ddc78a01e44e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.