1099107 - Implement new interface to allow users to select subject

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

In order to allow a user to change the conversation subject, new parameters will be added to the protocol.

This bug covers the interface using this new API with the Loop server

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Proposed patch (WIP)

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8523870 [details] [review]
Proposed patch (WIP)

LGTM, I left a comment, please take a look at github, thanks a lot

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8523870 [details] [review]
Proposed patch (WIP)

The code looks great as a WIP. Let's remove the logs and get the final version of the patch and let us know! Great job! Gracias! ;)

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8523870 [details] [review]
Proposed patch (WIP)

LGTM, left a comment about indentation in a line, the rest is perfect. Although you have to rebase the pr

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Rebased & Landed: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/6c50b87a6ea77706087cfc209838ddc78a01e44e