Fix compile problems on 'none' platform

RESOLVED FIXED in mozilla36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: lth, Assigned: lth)

Tracking

unspecified
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8523020 [details] [diff] [review]
NoneCompileProblem.diff

Recent changes to asm.js and baseline have broken the 'none' platform.
Attachment #8523020 - Flags: review?(benj)
Comment on attachment 8523020 [details] [diff] [review]
NoneCompileProblem.diff

Review of attachment 8523020 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: js/src/asmjs/AsmJSModule.cpp
@@ +1638,5 @@
>          CallSite &cs = callSites_[i];
>          if (cs.kind() != CallSite::Relative)
>              continue;
>  
> +#if !defined(JS_CODEGEN_NONE)

I think this change is unnecessary? CallSite is defined in Assembler-shared.h, which is included in MacroAssembler-none.h, so we should be fine here.
Attachment #8523020 - Flags: review?(benj) → review+
https://hg.mozilla.org/mozilla-central/rev/24ad66bc6c2b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.