Closed Bug 1099251 Opened 6 years ago Closed 6 years ago

make ChaosMode's behavior modifications more finely-grained selectable

Categories

(Core :: MFBT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

Enabling ChaosMode everywhere is a big hammer, and a surefire recipe for
turning tests orange.  My hypothesis is that making the different chaos-y
behaviors more finely selectable will enable more focused debugging.
Straightforward patch.  32 knobs to flip for chaos mode should be enough for
anybody.  I'll play around with this on Try before asking for review.
Comment on attachment 8523059 [details] [diff] [review]
make ChaosMode's behavior modifications more finely-grained selectable

Just flipping on hash table iteration chaos causes drastically fewer oranges:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d0071c94db3e

so I am going to call this patch a success.

Requesting review from roc rather than, say, Waldo, because roc landed ChaosMode originally and may have some comments.
Attachment #8523059 - Flags: review?(roc)
(In reply to Nathan Froyd (:froydnj) from comment #0)
> Enabling ChaosMode everywhere is a big hammer, and a surefire recipe for
> turning tests orange.  My hypothesis is that making the different chaos-y
> behaviors more finely selectable will enable more focused debugging.

The patch looks OK, but can you explain in more detail why this is valuable?
Flags: needinfo?(nfroyd)
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #3)
> (In reply to Nathan Froyd (:froydnj) from comment #0)
> > Enabling ChaosMode everywhere is a big hammer, and a surefire recipe for
> > turning tests orange.  My hypothesis is that making the different chaos-y
> > behaviors more finely selectable will enable more focused debugging.
> 
> The patch looks OK, but can you explain in more detail why this is valuable?

My idea is that it's easier to debug oranges (or to determine why they occur) if the chaos is limited to one easily understood behavior.  The original chaos mode turns everything orange; being able to narrow things down to one thing makes the subsequent oranges easier (IMHO) to deal with.
Flags: needinfo?(nfroyd)
https://hg.mozilla.org/mozilla-central/rev/f8863cbd49cb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.