[Gallery][RTL]- Not able to swipe in fullscreen view after viewing first image from thumbnail list

VERIFIED FIXED

Status

Firefox OS
Gaia
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: pdahiya, Assigned: pdahiya)

Tracking

(Blocks: 1 bug)

unspecified
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(b2g-v2.2 verified, b2g-master verified)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
In RTL mode, after opening first image in thumbnail list, user is not able to swipe to previous image.
STR

1. Set language to Arabic
2. Open gallery app and click on first image in thumbnail list
3. Swipe forward to view previous image

Expected: User should move to previous image

Actual: Stays stuck on first image in fullscreen view
(Assignee)

Updated

3 years ago
Blocks: 1087056
(Assignee)

Updated

3 years ago
Assignee: nobody → pdahiya
(Assignee)

Comment 1

3 years ago
User gets stuck and not able to swipe in fullscreen view when viewing last thumbnail item also.
(Assignee)

Comment 2

3 years ago
Created attachment 8526976 [details] [review]
PR with fix of Bug 1099458

Hi David
Please review attached PR that handles frameOffset reset to avoid swiping past the end of first and last item in RTL. Thanks!
Attachment #8526976 - Flags: review?(dflanagan)
Created attachment 8527006 [details]
more patch

This seems to fix the rest of the swiping issues.
Comment on attachment 8526976 [details] [review]
PR with fix of Bug 1099458

Punam,

Your patch looks good to me (except that I'd prefer to have the "normal" ltr case first and the rtl case in the else clause). So r+ on that. But I don't think the patch goes far enough. Please try out (and review) the patch I've just attached. I think that together with yours, that is a patch worth landing before Justin's refactor lands.

If my patch looks good to you, please go ahead and combine with your and land both. No additional review needed in that case.  Otherwise, just let me know if you have questions.
Attachment #8526976 - Flags: review?(dflanagan) → review+
(Assignee)

Comment 5

3 years ago
(In reply to David Flanagan [:djf] from comment #4)
> Comment on attachment 8526976 [details] [review]
> PR with fix of Bug 1099458
> 
> Punam,
> 
> Your patch looks good to me (except that I'd prefer to have the "normal" ltr
> case first and the rtl case in the else clause). So r+ on that. But I don't
> think the patch goes far enough. Please try out (and review) the patch I've
> just attached. I think that together with yours, that is a patch worth
> landing before Justin's refactor lands.

Agreed in RTL swiping experience is much better after swapping next and previous slides. 

> If my patch looks good to you, please go ahead and combine with your and
> land both. No additional review needed in that case.  Otherwise, just let me
> know if you have questions.
(Assignee)

Comment 6

3 years ago
I have updated the patch, waiting for green gaia-try run before landing.
(Assignee)

Comment 7

3 years ago
Patch landed on master
https://github.com/mozilla-b2g/gaia/commit/79003598a7ee5f93ecda26ec735b8a01053a9d0e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15913/
Flags: in-moztrap+

Comment 9

3 years ago
Created attachment 8605000 [details]
verify_video.mp4

This issue has been verified as pass on latest build of Flame 2.2/3.0 and Nexus 5 2.2/3.0 by STRs in comment 0.
Result: User can move to previous image.
See attachment:verify_video.mp4
Rate:0/3

Device: Flame 2.2 (affected)
Build ID               20150512002502
Gaia Revision          c4c1bf443f2b01c2ba918780510fd4c639a3c360
Gaia Date              2015-05-11 14:12:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/70782f19acbf
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150512.041644
Firmware Date          Tue May 12 04:16:55 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (affected)
Build ID               20150512160203
Gaia Revision          3654ec1d7ce1e0a56a34d5c3b06f6a9b33ff79ad
Gaia Date              2015-05-12 05:13:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/42db79f3cd6b
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150512.192015
Firmware Date          Tue May 12 19:20:26 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (affected)
Build ID               20150512002502
Gaia Revision          c4c1bf443f2b01c2ba918780510fd4c639a3c360
Gaia Date              2015-05-11 14:12:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/70782f19acbf
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150512.041312
Firmware Date          Tue May 12 04:13:28 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (affected)
Build ID               20150512160203
Gaia Revision          3654ec1d7ce1e0a56a34d5c3b06f6a9b33ff79ad
Gaia Date              2015-05-12 05:13:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/42db79f3cd6b
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150512.191625
Firmware Date          Tue May 12 19:16:41 EDT 2015
Bootloader             HHZ12f

Updated

3 years ago
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
status-b2g-v2.2: --- → verified
status-b2g-master: --- → verified
You need to log in before you can comment on or make changes to this bug.